Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce child options for service downtimes #1091

Merged
merged 2 commits into from
Dec 9, 2024
Merged

Introduce child options for service downtimes #1091

merged 2 commits into from
Dec 9, 2024

Conversation

nilmerg
Copy link
Member

@nilmerg nilmerg commented Nov 12, 2024 •
edited
Loading

ScheduleDowntimeCommand is basically what ScheduleServiceDowntimeCommand previously was. Though, with the addition of get|setForAllServices() which was only part of ScheduleHostDowntimeCommand.

ScheduleDowntimeCommand::get|setChildOption() is completely new and replaces ScheduleHostDowntimeCommand::get|setTriggered().

ScheduleHostDowntimeCommand, PropagateHostDowntimeCommand and ScheduleServiceDowntimeCommand are now deprecated.

fixes #1090

@nilmerg nilmerg added the bug Something isn't working label Nov 12, 2024
@nilmerg nilmerg added this to the 1.2.0 milestone Nov 12, 2024
@nilmerg nilmerg self-assigned this Nov 12, 2024
@cla-bot cla-bot bot added the cla/signed CLA is signed by all contributors of a PR label Nov 12, 2024
@nilmerg nilmerg changed the base branch from main to dependencies November 12, 2024 13:15
@nilmerg nilmerg force-pushed the fix/child-options-for-downtimes-1090 branch from f69a579 to 92e991b Compare November 12, 2024 13:17
@nilmerg
Copy link
Member Author

nilmerg commented Nov 12, 2024

@sukhwinder33445 You should now be able to force the scheduleDowntimeAction for redundancy groups to always assume a ScheduleHostDowntimeForm as source. But I didn't test, what will happen if a service downtime is scheduled with the all_services flag set. Either Icinga 2 ignores it, or complains about it. Please check this.

@nilmerg nilmerg force-pushed the fix/child-options-for-downtimes-1090 branch from 92e991b to 3bed8e8 Compare November 12, 2024 13:32
sukhwinder33445
sukhwinder33445 approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@sukhwinder33445 sukhwinder33445 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine.

@nilmerg
Introduce new class ScheduleDowntimeCommand
464a440 
Covers the full functionality of the schedule-downtime
endpoint of Icinga 2's api now.

fixes #1090
@nilmerg
Deprecate old type-specific schedule downtime commands
f85f893
@nilmerg nilmerg force-pushed the fix/child-options-for-downtimes-1090 branch from 3bed8e8 to f85f893 Compare December 9, 2024 11:51
@nilmerg nilmerg merged commit 9c86ab9 into dependencies Dec 9, 2024
22 checks passed
@nilmerg nilmerg deleted the fix/child-options-for-downtimes-1090 branch December 9, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sukhwinder33445 sukhwinder33445 sukhwinder33445 approved these changes

Assignees

@nilmerg nilmerg

Labels
bug Something isn't working cla/signed CLA is signed by all contributors of a PR
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

Proper dependency options while scheduling a downtime
2 participants
@nilmerg @sukhwinder33445