Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

D&D for subprocess doesn't work #404

Open
yhabteab opened this issue Aug 15, 2023 · 2 comments
Open

D&D for subprocess doesn't work #404

yhabteab opened this issue Aug 15, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@yhabteab
Copy link
Member

Describe the bug

Trying to reorder the children that also contain a subprocess results to this error:
Bildschirmfoto 2023-08-15 um 09 56 18
@yhabteab yhabteab added the bug Something isn't working label Aug 15, 2023
@yhabteab
Copy link
Member Author

yhabteab commented Aug 15, 2023 •
edited
Loading

How to reproduce

  1. Create a top-level process
  2. Add some children
  3. Store the config
  4. Add a new process as a subprocess
  5. Try to reorder the new created subprocess

@yhabteab yhabteab added this to the 2.5.0 milestone Aug 15, 2023
@sukhwinder33445 sukhwinder33445 removed their assignment Aug 24, 2023
@sukhwinder33445
Copy link
Contributor

sukhwinder33445 commented Aug 24, 2023 •
edited
Loading

This error occurs when the ID of the newly added subprocess is an int (step 4 above).

NodeMoveAction::applyTo() uses array_merge(), which reset array key if $name is int.

https://github.com/Icinga/icingaweb2-module-businessprocess/blob/master/library/Businessprocess/Modification/NodeMoveAction.php#L171-L175

@nilmerg nilmerg removed this from the 2.5.0 milestone Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nilmerg @sukhwinder33445 @yhabteab