Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate jobs and schedule config #194

Merged
merged 18 commits into from
Sep 14, 2023
Merged

Separate jobs and schedule config #194

merged 18 commits into from
Sep 14, 2023

Conversation

yhabteab
Copy link
Member

@yhabteab yhabteab commented Jul 19, 2023 •
edited
Loading

fixes #181

@cla-bot cla-bot bot added the cla/signed label Jul 19, 2023
@yhabteab yhabteab added the enhancement New feature or improvement label Jul 19, 2023
@yhabteab yhabteab added this to the 1.2.2 milestone Jul 19, 2023
@yhabteab yhabteab self-assigned this Jul 19, 2023
@yhabteab yhabteab force-pushed the separate-jobs-and-schedule-config branch 2 times, most recently from f910a21 to 2390953 Compare July 19, 2023 11:40
@yhabteab yhabteab mentioned this pull request Jul 19, 2023
Merged
@yhabteab yhabteab force-pushed the separate-jobs-and-schedule-config branch 2 times, most recently from e29b76c to 570b9f4 Compare July 19, 2023 14:45
@yhabteab yhabteab requested a review from lippserd July 19, 2023 15:22
lippserd
lippserd requested changes Jul 20, 2023
View reviewed changes
library/X509/Web/Widget/EmptyList.php Outdated Show resolved Hide resolved
@yhabteab yhabteab force-pushed the separate-jobs-and-schedule-config branch 6 times, most recently from fabf742 to 71d5488 Compare July 20, 2023 13:18
@yhabteab yhabteab requested a review from lippserd July 20, 2023 13:18
@yhabteab yhabteab force-pushed the separate-jobs-and-schedule-config branch 5 times, most recently from eb25f36 to 2beebb2 Compare July 31, 2023 13:16
lippserd
lippserd reviewed Aug 10, 2023
View reviewed changes
public/css/module.less Outdated Show resolved Hide resolved
lippserd
lippserd requested changes Aug 10, 2023
View reviewed changes
Copy link
Member

@lippserd lippserd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is the first set of requested changes. I'm not finished yet :).

Please also do the following:

  • Use translate() instead of t() where appropriate.
  • When setting tabs/controls/content in controllers I'd like to see the following flow:
// Code for tabs
// Newline
// Code for controls
// Newline
// Code for content

library/X509/Schedule.php Outdated Show resolved Hide resolved
library/X509/Schedule.php Outdated Show resolved Hide resolved
application/forms/Jobs/ScheduleForm.php Outdated Show resolved Hide resolved
application/forms/Jobs/ScheduleForm.php Show resolved Hide resolved
application/forms/Jobs/ScheduleForm.php Show resolved Hide resolved
application/controllers/JobController.php Outdated Show resolved Hide resolved
application/clicommands/JobsCommand.php Outdated Show resolved Hide resolved
application/clicommands/JobsCommand.php Outdated Show resolved Hide resolved
library/X509/Job.php Outdated Show resolved Hide resolved
library/X509/Job.php Outdated Show resolved Hide resolved
@yhabteab yhabteab force-pushed the separate-jobs-and-schedule-config branch from a354489 to 5657d27 Compare September 13, 2023 11:54
@yhabteab yhabteab requested a review from lippserd September 13, 2023 11:54
lippserd
lippserd previously approved these changes Sep 13, 2023
View reviewed changes
@yhabteab
Copy link
Member Author

@lippserd please check the latest 2 commits again.

@yhabteab yhabteab requested a review from lippserd September 13, 2023 14:23
@yhabteab yhabteab force-pushed the separate-jobs-and-schedule-config branch from db5947f to d8d38f0 Compare September 13, 2023 15:01
@yhabteab
Introduce Job & Schedule DB model
1bb060a
@yhabteab
Render Jobs section as sub section of module main menu
fe23643
@yhabteab
Separate Job & Schedule configs
329fdbd
@yhabteab
Load Jobs & Schedules from database for scanning
382dda4
@yhabteab
Document cli commands & enhance existing configuration docs
6ea1e56
@yhabteab
Drop JobsIniRepository
5df32e8
@yhabteab
Always perform a full scan when scheduling a job initially
c7b36d1
@yhabteab
Dont't disable exports for job list
a3915a7
@yhabteab
Update phpstan baseline config
57ffe78
@yhabteab
Don't use modal view in list views
cc39ad7
@yhabteab
Job: Add missing constant doc block
e723a5d
@yhabteab
JobsCommand: Enhance logging
3eda538
@yhabteab
Enhance docs
f432435
@yhabteab
Use EmptyStateBar where applicable
b56123c
@yhabteab
Expect parsed cidrs & ports in Job class & parse jobs config in cli c…
fc40499 
…ommands
@yhabteab
Add newline before return statement
1a0a54e
@yhabteab
Use Icinga Web instead of Icinga Web 2 as a component name
1bd6683
@yhabteab
Drop ignore error pattern matching Model::getKeyName() & `Model::ge…
c45935d 
…tColumns()` methods
@yhabteab yhabteab force-pushed the separate-jobs-and-schedule-config branch from d8d38f0 to c45935d Compare September 14, 2023 07:08
@yhabteab
Copy link
Member Author

Just rebased!

@yhabteab yhabteab merged commit 47afc99 into main Sep 14, 2023
6 checks passed
@yhabteab yhabteab deleted the separate-jobs-and-schedule-config branch September 14, 2023 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilmerg nilmerg nilmerg left review comments

@lippserd lippserd lippserd approved these changes

Assignees

@yhabteab yhabteab

Labels
cla/signed enhancement New feature or improvement
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.

Scan jobs run by daemon not updating allready scanned Targets
3 participants
@yhabteab @lippserd @nilmerg