-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve feedback on error in the application #173
Comments
As a first step, the web UI should report the error message returned by the backend to the user. There are only a few of these error messages, but the amount of potential cases would grow when addressing #496. |
We start reporting errors on the task create operation, in the following situations: * Overlapping tasks detected. * Trying to write to a date that has been locked. * Trying to assign a task to a project that's closed. These errors are detected prior to launching the SQL query. We haven't addressed SQL errors yet.
Danielle has started addressing #496, fixing this too in the process. |
This allows batchCreate to return an array of OperationResults, each potentially containing one error, and makes the UI go through all of them to report on screen.
This allows batchCreate to return an array of OperationResults, each potentially containing one error, and makes the UI go through all of them to report on screen.
We start reporting errors on the task create operation, in the following situations: * Overlapping tasks detected. * Trying to write to a date that has been locked. * Trying to assign a task to a project that's closed. These errors are detected prior to launching the SQL query. We haven't addressed SQL errors yet.
This allows batchCreate to return an array of OperationResults, each potentially containing one error, and makes the UI go through all of them to report on screen.
Merged in #616:
|
Make "error" font red and increase message time on screen.
Make "error" font red and increase message time on screen.
Make "error" font red and increase message time on screen.
Make "error" font red and increase message time on screen.
Make "error" font red, add an icon next to it and increase message time on screen.
The HybridUserDAO matches user data with the LDAP and keeps them in sync with the local database, to maintain the relations with other data tables. We modify the create operation in this DAO to return OperationResult, matching the new expectations of the upper layers. We change the Hybrid DAO to extend the Postgres DAO, so we can reuse the SQL operations. In this case, we call the create operation from the Postgres DAO after we do the corresponding LDAP checks.
This operation did not do anything related with LDAP, so we simply run the corresponding SQL operation. We don't modify the behavior of the operation, so we add a comment about a detected problem. In the web service layer, we add try/catch blocks for the LDAPInvalidOperationException like the ones in the create and delete user services, to prevent crashing on operations that aren't defined in the LDAP backend (namely, assigning users to groups).
Make "error" font red, add an icon next to it and increase message time on screen.
Merged in #618:
|
When updating a login name in the LDAP backend there is a risk of side effects. With this change, we are able to report the success message from the backend through the UI instead of overwriting it with another string, so we can warn users when doing that operation.
This operation did not do anything related with LDAP, so we simply run the corresponding SQL operation. We don't modify the behavior of the operation, so we add a comment about a detected problem. In the web service layer, we add try/catch blocks for the LDAPInvalidOperationException like the ones in the create and delete user services, to prevent crashing on operations that aren't defined in the LDAP backend (namely, assigning users to groups).
When updating a login name in the LDAP backend there is a risk of side effects. With this change, we are able to report the success message from the backend through the UI instead of overwriting it with another string, so we can warn users when doing that operation.
Merged in PR #621:
|
I think it is probably time to pause working on this one and spend the time on the new frontend so that we can benefit from the new technologies. |
[Trac import]
Reported by: jaragunde
Original date: Wednesday, 29 February 2012 14:36
The feedback when an error happens in !PhpReport is too generic and doesn't help the user to know what's wrong. Some examples:
Besides, the error notifications are too similar to 'ok' notifications, and they vanish too soon. It might happen that a user thinks he has saved his tasks correctly and he hasn't.
The text was updated successfully, but these errors were encountered: