Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(palette): update adaptive-contrast and color functions #384

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

feat(palette): update adaptive-contrast and color functions #384

wants to merge 19 commits into from

Conversation

didimmova
Copy link
Contributor

Closes #380

@didimmova didimmova added ❌ status: awaiting-test PRs awaiting manual verification palettes labels Feb 17, 2025
@didimmova didimmova requested a review from simeonoff February 17, 2025 07:25
@didimmova
Copy link
Contributor Author

test with this theming version in this PR

didimmova and others added 12 commits February 17, 2025 17:45
@didimmova
feat(color): update text-contrast function and palette mixin, remove …
40fe688 
…contrast function
@didimmova
Merge branch 'didimmova/text-contrast-function' of https://github.com…
c66fd1d 
…/IgniteUI/igniteui-theming into didimmova/text-contrast-function
@didimmova
feat(palette): revert text-contrast function and add accessible-color…
b2b7e1b 
…s one
@didimmova
feat(palette): add fallback for contrast level
85cde30
@simeonoff
Merge branch 'master' into didimmova/text-contrast-function
7bb476f
@simeonoff
refactor(colors): rename accsssible-colors function to adaptive-contrast
63512fb
@simeonoff
docs(colors): update sassdoc for adaptive colors
d0aeaf7
@didimmova
fix(colors): remove wrong parameter invocation
2eef76c
@simeonoff
refactor(colors): add adaptive-contrast mixin
d483c76
@simeonoff
refactor(color): improve adaptive-contrast function
b234984
@simeonoff
spec(colors): refactor adaptive color tests
7a17c72
@simeonoff
refactor(color): update color function and fix contrast shading
58b6392
@simeonoff simeonoff force-pushed the didimmova/text-contrast-function branch from 756e4ae to 58b6392 Compare February 21, 2025 07:15
simeonoff
simeonoff previously approved these changes Feb 21, 2025
View reviewed changes
@simeonoff simeonoff added ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification labels Feb 21, 2025
@simeonoff simeonoff assigned didimmova and unassigned simeonoff Feb 21, 2025
@simeonoff simeonoff changed the title feat(palette): update text-contrast and color functions feat(palette): update adaptive-contrast and color functions Feb 21, 2025
simeonoff
simeonoff reviewed Feb 21, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simeonoff simeonoff simeonoff left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@didimmova didimmova

Labels
palettes ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Palettes]: add support for CSS-runtime calculated contrast colors
2 participants
@didimmova @simeonoff