Skip to content

Conversation

@adrianptrv
Copy link
Contributor

@adrianptrv adrianptrv commented Oct 29, 2025

Closes: #1915
Requires this theming PR: 495

  • Replaced igx-icon with igc-icon in the Tabs WC demo (Angular project) to ensure the Tabs theme "icon" parameters work correctly. #16395
  • Also set up the newly added theme parameters - $item-active-hover-background $item-active-hover-color $item-active-hover-icon-color

@didimmova
Copy link
Contributor

didimmova commented Oct 30, 2025

Angular:
-No border radius applied in material theme


WC:


  • No border color
  • No border color hover


Disabled button is using button-background in angular and item-background for WC, check which one is right

Screen.Recording.2025-10-30.at.8.57.59.mov

@desig9stein
Copy link
Contributor

desig9stein commented Nov 4, 2025

THEME: INDIGO
It looks like item-active-background is not used anywhere in the Indigo theme, including in the Angular repo. Its current value also seems incorrect: when I apply it in the expected place, it renders as transparent. I believe it should use the same color as the item-hover-background, since that’s what is currently used in that state.

@adrianptrv
Copy link
Contributor Author

THEME: INDIGO It looks like item-active-background is not used anywhere in the Indigo theme, including in the Angular repo. Its current value also seems incorrect: when I apply it in the expected place, it renders as transparent. I believe it should use the same color as the item-hover-background, since that’s what is currently used in that state.

I have added and set up three new parameters for the active tab - $item-active-hover-background $item-active-hover-color $item-active-hover-icon-color
The changes can now be tested again using this theming PR: 495

@desig9stein
Copy link
Contributor

@adrianptrv, the active background is still not working. I should be able to see the active background on the active tab in the idle state and the active hover background when I hover the active tab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Tabs not fully styleable using Sass theme

5 participants