Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Withdraw Instruction #6

Open
alecchendev opened this issue Mar 7, 2022 · 0 comments · May be fixed by #15
Open

Withdraw Instruction #6

alecchendev opened this issue Mar 7, 2022 · 0 comments · May be fixed by #15
Assignees
@jdubpark
Labels
atomic Single task, well defined good first issue Good for newcomers

Comments

@alecchendev
Copy link
Member

alecchendev commented Mar 7, 2022 •
edited
Loading

Need to add an account to this instruction: the payer's token account for the token denoting ownership of the subscription. This is to ensure only the rightful owner of the subscription is able to withdraw funds from the deposit vault.

Implementing this check: 1. check that this token account's mint matches the mint specified in the subscription metadata 2. check the amount in the token account is > 0 3. bam
@alecchendev alecchendev added the good first issue Good for newcomers label Mar 7, 2022
@jdubpark jdubpark self-assigned this Mar 7, 2022
@jdubpark jdubpark linked a pull request Mar 10, 2022 that will close this issue
Open
@alecchendev alecchendev added the atomic Single task, well defined label Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jdubpark jdubpark

Labels
atomic Single task, well defined good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat/withdraw IlliniBlockchain/buoyant
Withdraw Instruction IlliniBlockchain/buoyant
2 participants
@jdubpark @alecchendev