Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Authentication #14

Open
mjneff2 opened this issue Apr 16, 2022 · 1 comment
Open

Authentication #14

mjneff2 opened this issue Apr 16, 2022 · 1 comment

Comments

@mjneff2
Copy link
Contributor

mjneff2 commented Apr 16, 2022

At some point we must add some sort authentication so users can only delete/modify their own Spots and Reviews. Will edit this issue further once we have a better idea of what we want for this.
@daviskeene
Copy link
Contributor

Personally, I don't think that users should have ownership of the study spots that they create. Reviews are more of a gray area for me, as people would have the option to give us their name.

We should have this conversation soon. Is our auth system going to be a JWT token, where requests are only valid if sent using the client? Should we have people optionally log in with Google in order to leave a review? I'm not sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@daviskeene @mjneff2