-
Notifications
You must be signed in to change notification settings - Fork 0
Add social media share buttons #102
Comments
We need to provide users an easy way to share pins to social media sites. There are several react packages out there that help provide this functionality but none really do it well, or I suck at implementing them. I have a branch https://github.com/PinsterTeam/Frontend/tree/newell/social_media_share which can be used as a starting point, I think I got most of the button generation working I just didn't have the CSS figured out. Also we'll need to generate the URLs to link back, but this feature isn't really useful until a user can link back to our page and have a specific pin open up.. perhaps we can hack this to link to a search query for that pin, or just the show page for the pin itself. This should be a pretty fast project for someone familiar with styling and stuff. |
I think we should nail down the pin-page/modal discussions before this gets too far in dev. There were discussions on making the modals use pin-page urls, etc but I don't think it ever made it to a ticket. |
Agreed. I think we need to flesh out and clean up the modal a bit more and
then tackle this once that all makes more sense.
…On Tue, Jun 5, 2018, 10:19 Mark Moser ***@***.***> wrote:
I think we should nail down the pin-page/modal discussions before this
gets too far in dev. There were discussions on making the modals use
pin-page urls, etc but I don't think it ever made it to a ticket.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#102 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AIx3mawnuujBrX4WomQdTeNeSfyagDBXks5t5pNkgaJpZM4UPjBV>
.
|
No description provided.
The text was updated successfully, but these errors were encountered: