Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[component/logo] Logo 컴포넌트 개발 #23

Merged
merged 2 commits into from
Mar 18, 2021
Merged

[component/logo] Logo 컴포넌트 개발 #23

merged 2 commits into from
Mar 18, 2021

Conversation

SeonHyungJo
Copy link
Member

  • className, width, height props 추가

re #18

@SeonHyungJo
feat(logo): logo 컴포넌트 개발
fb0f55a 
- className, width, height props 추가

re #18
@SeonHyungJo SeonHyungJo added the 새로운 기능 새로운 기능 추가했습니다. label Mar 10, 2021
@SeonHyungJo SeonHyungJo requested review from dididy and BKJang March 10, 2021 16:16
@SeonHyungJo SeonHyungJo linked an issue Mar 10, 2021 that may be closed by this pull request
Logo Component 개발 #18
Open
dididy
dididy approved these changes Mar 10, 2021
View reviewed changes
Copy link
Collaborator

@dididy dididy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

승인합니다!

dididy
dididy reviewed Mar 11, 2021
View reviewed changes
src/atoms/Logo/index.tsx Outdated
}

export default function Logo({
className,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SeonHyungJo 이부분도 null이 될 수 있으니 default parameter를 넣어야 하지 않을까요?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋은 의견입니다. 반영하였습니다. 추가적으로 모든 props 항목을 optional로 전환하였습니다.

BKJang
BKJang approved these changes Mar 18, 2021
View reviewed changes
Copy link
Member

@BKJang BKJang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 👍

@BKJang BKJang merged commit 1e59dd6 into develop Mar 18, 2021
@BKJang BKJang deleted the component/logo branch March 18, 2021 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dididy dididy dididy approved these changes

@BKJang BKJang BKJang approved these changes

Assignees
No one assigned
Labels
새로운 기능 새로운 기능 추가했습니다.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Logo Component 개발
3 participants
@SeonHyungJo @dididy @BKJang