From 365d024b3bdd467fc54a592ebb7cc9d2ff7289b3 Mon Sep 17 00:00:00 2001 From: Murray Stevenson <50844517+murraystevenson@users.noreply.github.com> Date: Fri, 8 Nov 2024 16:45:57 +1100 Subject: [PATCH 1/3] CI : Drop linux-gcc9 builds --- .github/workflows/main.yml | 22 ++++++---------------- 1 file changed, 6 insertions(+), 16 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 7482cd07b6..2ae7b991d6 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -30,41 +30,31 @@ jobs: # and then use `include` to define their settings. name: [ - linux-gcc9, - linux-debug-gcc9, linux-gcc11, + linux-debug-gcc11, windows, windows-debug ] include: - - name: linux-gcc9 + - name: linux-gcc11 os: ubuntu-20.04 buildType: RELEASE - containerImage: ghcr.io/gafferhq/build/build:2.1.2 + containerImage: ghcr.io/gafferhq/build/build:3.0.0 options: .github/workflows/main/options.posix - dependenciesURL: https://github.com/GafferHQ/dependencies/releases/download/8.0.1/gafferDependencies-8.0.1-linux-gcc9.tar.gz + dependenciesURL: https://github.com/GafferHQ/dependencies/releases/download/8.0.1/gafferDependencies-8.0.1-linux-gcc11.tar.gz tests: testCore testCorePython testScene testImage testAlembic testUSD testVDB publish: true - - name: linux-debug-gcc9 + - name: linux-debug-gcc11 os: ubuntu-20.04 buildType: DEBUG - containerImage: ghcr.io/gafferhq/build/build:2.1.2 - options: .github/workflows/main/options.posix - dependenciesURL: https://github.com/GafferHQ/dependencies/releases/download/8.0.1/gafferDependencies-8.0.1-linux-gcc9.tar.gz - tests: testCore testCorePython testScene testImage testAlembic testUSD testVDB - publish: false - - - name: linux-gcc11 - os: ubuntu-20.04 - buildType: RELEASE containerImage: ghcr.io/gafferhq/build/build:3.0.0 options: .github/workflows/main/options.posix dependenciesURL: https://github.com/GafferHQ/dependencies/releases/download/8.0.1/gafferDependencies-8.0.1-linux-gcc11.tar.gz tests: testCore testCorePython testScene testImage testAlembic testUSD testVDB - publish: true + publish: false - name: windows os: windows-2019 From ab3bd142a41a968ef9b0c28f1f47661782e196de Mon Sep 17 00:00:00 2001 From: Murray Stevenson <50844517+murraystevenson@users.noreply.github.com> Date: Fri, 8 Nov 2024 16:49:23 +1100 Subject: [PATCH 2/3] CI : Update to Node20 actions This is possible now that we're no longer producing linux-gcc9 builds from the CentOS 7 container, which can't run Node20 actions. --- .github/workflows/main.yml | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 2ae7b991d6..02a6c2d877 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -76,17 +76,11 @@ jobs: container: ${{ matrix.containerImage }} - env: - # GitHub have moved to running actions on Node20, which prevents them from - # running on CentOS 7. The below allows actions to continue running on Node16 - # until October. - ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true - steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - - uses: ilammy/msvc-dev-cmd@v1.12.1 + - uses: ilammy/msvc-dev-cmd@v1.13.0 with: sdk: 10.0.17763.0 @@ -151,7 +145,7 @@ jobs: shell: bash - name: Cache - uses: actions/cache@v3 + uses: actions/cache@v4 with: path: sconsCache key: ${{ runner.os }}-${{ matrix.containerImage }}-${{env.CORTEX_DEPENDENCIES_HASH}}-${{ matrix.buildType }}-${{ github.sha }} @@ -178,10 +172,13 @@ jobs: ${{ env.PACKAGE_COMMAND }} ${{ env.CORTEX_BUILD_NAME }}.${{env.PACKAGE_EXTENSION}} ${{ env.CORTEX_BUILD_NAME }} if: matrix.publish - - uses: actions/upload-artifact@v3 + - uses: actions/upload-artifact@v4 with: name: ${{ env.CORTEX_BUILD_NAME }} path: ${{ env.CORTEX_BUILD_NAME }}.${{ env.PACKAGE_EXTENSION }} + # Using compression-level 0 avoids compressing our already compressed + # package and results in a significantly faster upload. + compression-level: 0 if: matrix.publish - name: Publish Release From 1a78c8126d5c6e8ef4e74e8e8407a6fa54504399 Mon Sep 17 00:00:00 2001 From: Murray Stevenson <50844517+murraystevenson@users.noreply.github.com> Date: Fri, 8 Nov 2024 16:50:48 +1100 Subject: [PATCH 3/3] CI : Increase build jobs to `4` --- .github/workflows/main.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 02a6c2d877..9f71605ebd 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -154,7 +154,7 @@ jobs: - name: Build run: | - scons -j 2 BUILD_TYPE=${{ matrix.buildType }} OPTIONS=${{ matrix.options }} BUILD_CACHEDIR=sconsCache + scons -j 4 BUILD_TYPE=${{ matrix.buildType }} OPTIONS=${{ matrix.options }} BUILD_CACHEDIR=sconsCache # Copy the config log for use in the "Debug Failures" step, because it # gets clobbered by the `scons test*` call below. cp config.log buildConfig.log