Method Element::matches() allows check children nodes

Imangazaliev · Imangazaliev · commit 69ab6a013e77 · 2017-05-14T22:12:26.000+03:00
diff --git a/src/DiDom/Element.php b/src/DiDom/Element.php
@@ -263,7 +263,7 @@ public function matches($selector, $strict = false)
                 throw new LogicException('Node must be an instance of DOMElement');
             }
 
-            $innerHtml = $node->ownerDocument->saveXml($node, LIBXML_NOEMPTYTAG);
+            $innerHtml = $this->html();
             $html = "<root>$innerHtml</root>";
 
             $selector = 'root > '.trim($selector);
diff --git a/tests/DiDom/ElementTest.php b/tests/DiDom/ElementTest.php
@@ -340,6 +340,25 @@ public function testMatches()
         $element = new Element('p');
 
         $this->assertTrue($element->matches('p', true));
+
+        $html = '<!DOCTYPE html>
+        <html lang="en">
+        <head>
+            <meta charset="UTF-8">
+            <title>Document</title>
+        </head>
+        <body>
+            <a href="#"><img src="foo.jpg" alt="Foo"></a>
+        </body>
+        </html>';
+
+        $document = new Document($html, false);
+        $anchor = $document->first('a');
+
+        $this->assertTrue($anchor->matches('a:has(img[src$=".jpg"])'));
+        $this->assertTrue($anchor->matches('a img'));
+        $this->assertFalse($anchor->matches('a img[alt="Bar"]'));
+        $this->assertFalse($anchor->matches('img'));
     }
 
     public function testHasAttribute()

Original file line number	Diff line number	Diff line change
`@@ -263,7 +263,7 @@ public function matches($selector, $strict = false)`
`263`	`263`	`throw new LogicException('Node must be an instance of DOMElement');`
`264`	`264`	`}`
`265`	`265`
`266`		`- $innerHtml = $node->ownerDocument->saveXml($node, LIBXML_NOEMPTYTAG);`
	`266`	`+ $innerHtml = $this->html();`
`267`	`267`	`$html = "<root>$innerHtml</root>";`
`268`	`268`
`269`	`269`	`$selector = 'root > '.trim($selector);`