Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Python3.6+ compliant #26

Open
3 of 6 tasks
deadbits opened this issue Aug 28, 2018 · 4 comments
Open
3 of 6 tasks

Make Python3.6+ compliant #26

deadbits opened this issue Aug 28, 2018 · 4 comments

Comments

@deadbits
Copy link
Contributor

To get a wider user base and ensure we can support both Python2.7 and Python3.6+, we'll need to make some changes:

  • Ensure all dependencies from requirements.txt are Py3.6+ compatible
  • Ensure all exceptions are handled correctly
  • Handle print as print(foo) versus print foo
  • Use fstrings and new format method in places where it makes sense:
  • ...
  • ... ongoing as I find more requirements
new: info(f'{artifact} tags: {result}')

original: info('%s tags: %s' % (artifact, result))
new: 
build_version = 'v{}.{}-{}_{}'.format(__app_major, rev_count.strip(), rev_hash.strip(), __app_stage)
app_version = 'v{}.{}_{}'.format(__app_major, rev_count.strip(), __app_stage)

old:
build_version = 'v%s.%s-%s_%s' % (__app_major, rev_count.strip(), rev_hash.strip(), __app_stage)
app_version = 'v%s.%s_%s' % (__app_major, rev_count.strip(), __app_stage)
@deadbits deadbits self-assigned this Aug 28, 2018
@deadbits deadbits added this to Backlog in Version 1.0 via automation Aug 28, 2018
@q2dg
Copy link

q2dg commented Aug 2, 2020

If this issue isn't resolved, this project is dead

@cmmorrow
Copy link

cmmorrow commented Aug 3, 2020

Hey @q2dg , I'll see if I can add py3 compatibility to this project.

@cmmorrow cmmorrow self-assigned this Aug 3, 2020
@deadbits
Copy link
Contributor Author

deadbits commented Aug 4, 2020

Hey all,

I will happily merge any PRs for Py3 compatability and I definitely appreciate the interest in this project. Unfortunately I haven't had much time to activately maintain this- I hope this changes in the near future, but anything I can do to facilitate support here let me know

@cmmorrow
Copy link

Starting on this now. I'll keep everyone updated on the status.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Version 1.0
  
Backlog
Development

No branches or pull requests

3 participants