Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable for private repositories by default? #2

Open
zhouzi opened this issue Aug 14, 2022 · 1 comment
Open

Disable for private repositories by default? #2

zhouzi opened this issue Aug 14, 2022 · 1 comment

Comments

@zhouzi
Copy link

zhouzi commented Aug 14, 2022

Congrats on the idea, it works well and it's pretty cool.

I have one concern though, the extension does work with private repositories. Looking at the code, it sends some of the repository's data to your servers. Would it be possible to disable that by default and add an option to enable it explicitly, with the appropriate warnings?

Also, I am surprised that the API endpoint https://git.indexstorm.com/similar is not listed in the manifest.json's permissions. I thought the browser wouldn't allow making requests without that. I think it would be great to add it regardless, this way users are informed in the web store and extension's page that it sends data to an API.

Overall it would show that the extension cares about privacy and it's more trustworthy. Let me know what you think and perhaps I can submit a PR!

@panckreous
Copy link

Just came here to report the same thing. (And to thank you for the Firefox extension)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants