Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of indiciaData.mapdiv makes assumption that only one map on form. #4

Open
Gary-van-Breda opened this issue Jun 7, 2016 · 1 comment
Labels

Comments

@Gary-van-Breda
Copy link
Contributor

Applies to client_helpers as well: primarily impacts map_helper, though a lot of forms use it.
When a form uses 2 maps - e.g. the sectioned transect input transect form and its derivatives (e.g. ukbms) - the indiciaData.mapdiv gets set to the second map initialised. This means things like find me and the tabbed map redraw don't work on the primary (first) map . It is also used in the reporting and associated filters a lot.
I believe its use in its current form needs to be reviewed.

@johnvanbreda
Copy link
Contributor

Agreed, though I think it has always been this way. There are a few instances where we reparent the map onto a different container then call map.updateSize if it is needed in 2 places.

@johnvanbreda johnvanbreda removed their assignment Jun 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants