Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to HTTP Responder for static type examples #11

Open
2 tasks
indigo-jay opened this issue Mar 4, 2023 · 0 comments
Open
2 tasks

Changes to HTTP Responder for static type examples #11

indigo-jay opened this issue Mar 4, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@indigo-jay
Copy link
Contributor

The method to return a static file in this plugin seems to have generated some confusion. Suggestions:

  • Update it with clear language that there are 3 ways to deliver static content:
    • Automatically via the /Resources/ directory
    • Semi-automatically by returning indigo.utils.return_static_file (handle_static_file_request shows this by delivering a custom 404 html file)
    • By streaming returning the contents of the file yourself (handle_static_file_request shows this)
  • Change the indigo.utils.FILE_EXTENSION_MIME_MAP lookup to use mimetypes.guess_type instead since that is now built-in (at least with Python 3.10).
@indigo-jay indigo-jay added the enhancement New feature or request label Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant