Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it easier to send replies in TIdEventSocksServer event handlers #512

Open
rlebeau opened this issue Dec 9, 2023 · 0 comments
Open

Make it easier to send replies in TIdEventSocksServer event handlers #512

rlebeau opened this issue Dec 9, 2023 · 0 comments
Labels
Element: SOCKS Issues related to TIdSocksInfo and TIdSocksServer Status: Reported Issue has been reported for review Type: Enhancement Issue is proposing a new feature/enhancement

Comments

@rlebeau
Copy link
Member

rlebeau commented Dec 9, 2023

From VA1DER (Kurt Fitzner) on Gitter:

As a suggestion, it would be handy if SendV4Response/SendV5Response were publicly accessible in IdSocksServer.pas. This would make it easier for TIdEventSocksServer to send replies in the OnCommandConnect event. As it stands, the user has to mess around with raw bytes and socks versions. Even better might be a simple TIdEventSocksServer.Reply(status) that will do the right thing regardless of the SOCKS version of the client.
@rlebeau rlebeau added Type: Enhancement Issue is proposing a new feature/enhancement Element: SOCKS Issues related to TIdSocksInfo and TIdSocksServer Status: Reported Issue has been reported for review labels Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Element: SOCKS Issues related to TIdSocksInfo and TIdSocksServer Status: Reported Issue has been reported for review Type: Enhancement Issue is proposing a new feature/enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rlebeau