Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow the files option to accept directories #73

Closed
Jamalam360 opened this issue Jun 18, 2024 · 2 comments · Fixed by #116
Closed

Allow the files option to accept directories #73

Jamalam360 opened this issue Jun 18, 2024 · 2 comments · Fixed by #116
Labels
enhancement New feature or request module Topic: The minecraft-servers module

Comments

@Jamalam360
Copy link

Forgive my ignorance if this isn't possible, but it would be nice if the files option could accept directories.

The symlinks option does not work for the config folder since it needs to be writable (this is mentioned in the files option docs). I'd rather not specify every config file individually in the files option 😂
@Jamalam360
Copy link
Author

For now I'm working around using the function in https://github.com/Infinidoge/nix-minecraft/pull/43/files

@Infinidoge Infinidoge added enhancement New feature or request module Topic: The minecraft-servers module labels Aug 8, 2024
Misterio77 added a commit to Misterio77/nix-minecraft that referenced this issue Dec 26, 2024
@Misterio77
refactor file & symlink
20ce627 
The new system works by adding a file attribute (user.nix-minecraft-managed) to managed files and symlinks. This makes it possible to correctly cleanup managed files (when stopping, restarting, reloading).

I've also added support for directories (Infinidoge#73), and ensured only non-binary files are substituted with env vars (Infinidoge#70)
@Misterio77 Misterio77 mentioned this issue Dec 26, 2024
Merged
@Misterio77
Copy link
Contributor

Will be fixed by #116

Misterio77 added a commit to Misterio77/nix-minecraft that referenced this issue Dec 27, 2024
@Misterio77
refactor file & symlink
9da4202 
The new system works by adding a file (.nix-minecraft-managed) to track managed files and symlinks. This makes it possible to correctly cleanup managed files (when stopping, restarting, reloading).

I've also added support for directories (Infinidoge#73), and ensured only non-binary files are substituted with env vars (Infinidoge#70)
Misterio77 added a commit to Misterio77/nix-minecraft that referenced this issue Dec 27, 2024
@Misterio77
refactor file & symlink
19349a5 
The new system works by adding a file (.nix-minecraft-managed) to track managed files and symlinks. This makes it possible to correctly cleanup managed files (when stopping, restarting, reloading).

I've also added support for directories (Infinidoge#73), and ensured only non-binary files are substituted with env vars (Infinidoge#70)
Misterio77 added a commit to Misterio77/nix-minecraft that referenced this issue Dec 28, 2024
@Misterio77
refactor file & symlink
2db9fee 
The new system works by adding a file (.nix-minecraft-managed) to track managed files and symlinks. This makes it possible to correctly cleanup managed files (when stopping, restarting, reloading).

I've also added support for directories (Infinidoge#73), and ensured only non-binary files are substituted with env vars (Infinidoge#70)
Misterio77 added a commit to Misterio77/nix-minecraft that referenced this issue Dec 29, 2024
@Misterio77
refactor file & symlink
5d32b16 
The new system works by adding a file (.nix-minecraft-managed) to track managed files and symlinks. This makes it possible to correctly cleanup managed files (when stopping, restarting, reloading).

I've also added support for directories (Infinidoge#73), and ensured only non-binary files are substituted with env vars (Infinidoge#70)
Infinidoge pushed a commit that referenced this issue Dec 29, 2024
@Misterio77
module: refactor file & symlink (#116)
3003c8c 
The new system works by adding a file (.nix-minecraft-managed) to track managed files and symlinks. This makes it possible to correctly cleanup managed files (when stopping, restarting, reloading).

I've also added support for directories (#73), and ensured only non-binary files are substituted with env vars (#70)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request module Topic: The minecraft-servers module
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor file & symlink Misterio77/nix-minecraft
3 participants
@Misterio77 @Infinidoge @Jamalam360