Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ability to offer a draw #9

Closed
this-is-not-available opened this issue Jul 9, 2024 · 6 comments
Closed

Implement ability to offer a draw #9

this-is-not-available opened this issue Jul 9, 2024 · 6 comments
Labels
enhancement New feature or request

Comments

@this-is-not-available
Copy link
Contributor

Currently, offering a draw just kind of does nothing:
case 'offerdraw': console.error("Don't know how to offer draw yet.")

So, someday someone needs to implement this.

It's not a bug fix and also not a database migration,
but somewhere in the middle, where it will take somewhere around 1 to 3 days.

@Naviary2 Naviary2 added the enhancement New feature or request label Jul 9, 2024
@Naviary2
Copy link
Member

Naviary2 commented Jul 9, 2024

Yes! This will be nice! I've been thinking the UI needs an update. The main menu (or return to lobby) button should be along the bottom of the screen instead of hidden within the pause menu. The offer draw button should be close to that. Players usernames should hyperlink to their profile, and display their elo, etc!

This will be tagged as an "enhancement" (or feature request)!

@MGGSK
Copy link

MGGSK commented Jul 9, 2024

Also don't allow players to spam draw offers.

@this-is-not-available
Copy link
Contributor Author

@Naviary2
Copy link
Member

#39 Here's the linked PR adding this

@this-is-not-available
Copy link
Contributor Author

this-is-not-available commented Jul 10, 2024

Yes that's my work right there. Beautiful

@this-is-not-available
Copy link
Contributor Author

Bruh we didn't close this. Now it is closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants