From 91c9e295b14e77a7b733fc85fadbcd85392c3c24 Mon Sep 17 00:00:00 2001 From: Supyovalk <78502804+Supyovalk@users.noreply.github.com> Date: Mon, 15 Jul 2024 21:30:39 +0300 Subject: [PATCH 1/3] Game Conclusion Check - condensed return value function will return false victor === oppositeColor, and true otherwise so it's equal to returning the opposite of the statement. --- src/server/game/gamemanager.js | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/server/game/gamemanager.js b/src/server/game/gamemanager.js index 81a94c816..ccc5ac266 100644 --- a/src/server/game/gamemanager.js +++ b/src/server/game/gamemanager.js @@ -184,7 +184,7 @@ const gamemanager = (function() { * @returns */ async function logGame(game) { - if (game.moves.length === 0) return; // Don't log + if (game.moves.length 0) return; // Don't log // First line of log... @@ -1224,9 +1224,7 @@ const gamemanager = (function() { // Game conclusion is decisive... // We can't submit a move where our opponent wins const oppositeColor = math1.getOppositeColor(color); - if (victor === oppositeColor) return false; - - return true; + return !(victor === oppositeColor); } /** @@ -1544,4 +1542,4 @@ const gamemanager = (function() { }) })(); -module.exports = gamemanager \ No newline at end of file +module.exports = gamemanager From 6db93b3ebb9efbd743b209780ef6e8f35683d169 Mon Sep 17 00:00:00 2001 From: Supyovalk <78502804+Supyovalk@users.noreply.github.com> Date: Mon, 15 Jul 2024 21:33:02 +0300 Subject: [PATCH 2/3] Retyped a === --- src/server/game/gamemanager.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/server/game/gamemanager.js b/src/server/game/gamemanager.js index ccc5ac266..4c1c53216 100644 --- a/src/server/game/gamemanager.js +++ b/src/server/game/gamemanager.js @@ -184,7 +184,7 @@ const gamemanager = (function() { * @returns */ async function logGame(game) { - if (game.moves.length 0) return; // Don't log + if (game.moves.length === 0) return; // Don't log // First line of log... From 36f6aea4ee75c30721220f195ead511abb35e880 Mon Sep 17 00:00:00 2001 From: Naviary <163621561+Naviary2@users.noreply.github.com> Date: Mon, 15 Jul 2024 15:22:15 -0600 Subject: [PATCH 3/3] even better! --- src/server/game/gamemanager.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/server/game/gamemanager.js b/src/server/game/gamemanager.js index 4c1c53216..65e2d4beb 100644 --- a/src/server/game/gamemanager.js +++ b/src/server/game/gamemanager.js @@ -1224,7 +1224,7 @@ const gamemanager = (function() { // Game conclusion is decisive... // We can't submit a move where our opponent wins const oppositeColor = math1.getOppositeColor(color); - return !(victor === oppositeColor); + return victor !== oppositeColor; } /**