Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API returns an error if >1000 results #24

Open
yohancourbe opened this issue Dec 19, 2017 · 1 comment
Open

API returns an error if >1000 results #24

yohancourbe opened this issue Dec 19, 2017 · 1 comment

Comments

@yohancourbe
Copy link

The API returns an error if it returns more than 1000 elements. The API supports an input _max_results which can take negative and positive integer:

  • A negative number will return an error if the maximum is reached
  • A positive number will limit return the maximum elements without triggering an error

By default this value is -1000 which means that if you have more than 1000 elements to return you will receive an error.

I suggest two edits:

  1. Implement an input to all getters that can return more than one element
  2. Implement an exception raising for this API error
@yohancourbe
Copy link
Author

I already made the changes for my fist suggestion, can I make a pull request ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant