Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UntrustedGroovyDatasetStepSpec nobbled if TRAVIS or CI is set #73

Open
alanbchristie opened this issue Aug 13, 2019 · 1 comment
Open

Comments

@alanbchristie
Copy link
Contributor

The changes for issue #72 have resulted in the tests defined in UntrustedGroovyDatasetStepSpec.groovy being disabled (if TRAVIS is defined). This is because the tests rely on access to /var/maven_repo - something not pleasant for Ci/CD.

We need to re-instate/fix/remove these tests.

@alanbchristie alanbchristie changed the title UntrustedGroovyDatasetStepSpec nobbled if TRAVIS is set UntrustedGroovyDatasetStepSpec nobbled if TRAVIS or CI is set Feb 17, 2021
@alanbchristie
Copy link
Contributor Author

alanbchristie commented Feb 17, 2021

Current thinking is to remove the tests - they require some unpleasant capability - i.e. access to /var.

For now, if the Groovy tests fail, i.e. if you see these failures: -

org.squonk.execution.steps.impl.UntrustedGroovyDatasetStepSpec > simple copy dataset FAILED
    com.github.dockerjava.api.exception.NotFoundException at UntrustedGroovyDatasetStepSpec.groovy:85

org.squonk.execution.steps.impl.UntrustedGroovyDatasetStepSpec > groovy consumer FAILED
    com.github.dockerjava.api.exception.NotFoundException at UntrustedGroovyDatasetStepSpec.groovy:115

org.squonk.execution.steps.impl.UntrustedGroovyDatasetStepSpec > groovy function FAILED
    com.github.dockerjava.api.exception.NotFoundException at UntrustedGroovyDatasetStepSpec.groovy:150

Then simulate the CI environment and build like this...

$ CI=yes ./gradlew build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant