From 973cf1367b8a775ac6496374144b7e6a17a4e46c Mon Sep 17 00:00:00 2001 From: Max Date: Wed, 11 Sep 2024 18:33:04 +0200 Subject: [PATCH] fix: keyring unit test when using OS keyring --- .github/workflows/run-tests.yml | 7 +++++++ client/keyring/keyring_errors_test.go | 4 ++-- client/keyring/keyring_test.go | 6 ++++-- 3 files changed, 13 insertions(+), 4 deletions(-) diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index 9236e281..4845bdaf 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -15,6 +15,13 @@ jobs: with: go-version-file: "go.mod" check-latest: true + - name: Install pass helper + run: sudo apt-get update && sudo apt-get install -y pass + - name: Generate GPG key + run: " + echo \"%no-protection\nKey-Type: 1\nKey-Length: 4096\nSubkey-Type: 1\nSubkey-Length: 4096\nName-Comment: keyring_test\nExpire-Date: 0\" > genkey && gpg --gen-key --batch genkey" + - name: Setup OS keystore + run: pass init keyring_test - name: Run test and calculate coverage run: make coverage - name: Upload coverage to Codecov diff --git a/client/keyring/keyring_errors_test.go b/client/keyring/keyring_errors_test.go index 8ff13cb0..f2f3d52c 100644 --- a/client/keyring/keyring_errors_test.go +++ b/client/keyring/keyring_errors_test.go @@ -112,7 +112,7 @@ func (s *KeyringTestSuite) TestErrKeyIncompatible() { }) testKeyring, err := cosmkeyring.New( - "keyring_test", + KeyringAppName, cosmkeyring.BackendTest, kbDir, nil, @@ -128,7 +128,7 @@ func (s *KeyringTestSuite) TestErrKeyIncompatible() { s.cdc, WithKeyringBackend(BackendTest), WithKeyringDir(kbDir), - WithKeyringAppName("keyring_test"), + WithKeyringAppName(KeyringAppName), WithKey( WithKeyFrom("test_pubkey"), ), diff --git a/client/keyring/keyring_test.go b/client/keyring/keyring_test.go index 990e1645..38693b7b 100644 --- a/client/keyring/keyring_test.go +++ b/client/keyring/keyring_test.go @@ -18,6 +18,8 @@ import ( "github.com/InjectiveLabs/sdk-go/client/chain" ) +const KeyringAppName = "keyring_test" + type KeyringTestSuite struct { suite.Suite @@ -151,7 +153,7 @@ func (s *KeyringTestSuite) TestKeyringOsWithAppName() { requireT := require.New(s.T()) osKeyring, err := cosmkeyring.New( - "keyring_test", + KeyringAppName, cosmkeyring.BackendOS, "", nil, @@ -188,7 +190,7 @@ func (s *KeyringTestSuite) TestKeyringOsWithAppName() { accAddr, kb, err := NewCosmosKeyring( s.cdc, WithKeyringBackend(BackendOS), - WithKeyringAppName("keyring_test"), + WithKeyringAppName(KeyringAppName), WithKey( WithKeyFrom("test"), ),