feat/add chain values converters #202
Conversation
aarmoa
commented
Jan 15, 2024
aarmoa
commented
- Added new functions in all Market classes to convert values from extended chain format (the ones provided by chain streams) into human-readable format
- Updated proto definitions for Indexer node using version v1.12.79.1
- Updated market and tokens INI configuration files
…ded chain format into human readable format. Updated Indexer proto definitions pointing to 1.12.79.1
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #202 +/- ##
==========================================
+ Coverage 29.46% 29.71% +0.25%
==========================================
Files 17 17
Lines 2552 2564 +12
==========================================
+ Hits 752 762 +10
- Misses 1764 1766 +2
Partials 36 36 ☔ View full report in Codecov by Sentry. |
client/core/market.go
Outdated
| } | ||
|
|
||
| func (spotMarket SpotMarket) fromExtendedChainformat(chainValue decimal.Decimal) decimal.Decimal { | ||
| return chainValue.Div(decimal.New(1, AdditionalChainFormatDecimals)) |
There was a problem hiding this comment.
Better to do this in utils file, this one doesn't depend on spotMarket or derivativeMarket
fromExtendedChainformat(chainValue decimal.Decimal) decimal.Decimal
But why chainValue has decimal.Decimal type?
There was a problem hiding this comment.
Ok, will move it (unfortunately moving it to utils makes it less OOP, something that I don't really like)
Regarding the chainValue, it was not originally decimal.Decimal. But the function that calls this one first translates the value according to market tokens decimals, making it a decimal.Decimal
There was a problem hiding this comment.
unfortunately moving it to utils makes it less OOP, something that I don't really like
Yeah it's a tool and we need flexibility to choose which to use
Regarding the chainValue, it was not originally decimal.Decimal. But the function that calls this one first translates the value according to market tokens decimals, making it a decimal.Decimal
Oh I thought using sdk.Dec is enough when chain streamed the value
