Feat/add distribution module examples #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… `distribution` module
WalkthroughThe recent update brings significant enhancements to the Changes
TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #208 +/- ##
==========================================
- Coverage 29.71% 29.01% -0.71%
==========================================
Files 17 17
Lines 2564 2630 +66
==========================================
+ Hits 762 763 +1
- Misses 1766 1831 +65
Partials 36 36 ☔ View full report in Codecov by Sentry. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 19
Configuration used: .coderabbit.yaml
Files selected for processing (15)
- .coderabbit.yaml (1 hunks)
- client/chain/chain.go (5 hunks)
- client/chain/chain_test_support.go (2 hunks)
- examples/chain/distribution/1_SetWithdrawAddress/example.go (1 hunks)
- examples/chain/distribution/3_WithdrawValidatorCommission/example.go (1 hunks)
- examples/chain/distribution/4_FundCommunityPool/example.go (1 hunks)
- examples/chain/distribution/query/1_ValidatorDistributionInfo/example.go (1 hunks)
- examples/chain/distribution/query/2_ValidatorOutstandingRewards/example.go (1 hunks)
- examples/chain/distribution/query/3_ValidatorCommission/example.go (1 hunks)
- examples/chain/distribution/query/4_ValidatorSlashes/example.go (1 hunks)
- examples/chain/distribution/query/5_DelegationRewards/example.go (1 hunks)
- examples/chain/distribution/query/6_DelegationTotalRewards/example.go (1 hunks)
- examples/chain/distribution/query/7_DelegatorValidators/example.go (1 hunks)
- examples/chain/distribution/query/8_DelegatorWithdrawAddress/example.go (1 hunks)
- examples/chain/distribution/query/9_CommunityPool/example.go (1 hunks)
Additional comments: 5
.coderabbit.yaml (1)
- 1-8: The automation configuration in
.coderabbit.yamllooks good and aligns with standard development workflows. It's a great addition for streamlining the review and chat reply process based on the specified base branches.client/chain/chain.go (4)
- 171-180: The addition of methods related to the distribution module in the
ChainClientinterface is correctly implemented. These methods cover a wide range of functionalities necessary for interacting with the distribution aspects of a blockchain network, such as fetching validator distribution info, outstanding rewards, commissions, slashes, delegation rewards, total rewards, delegator validators, delegator withdraw address, and community pool details. This expansion aligns with the PR objectives and enhances the library's capabilities significantly.- 217-217: The inclusion of the
distributionQueryClientfield in thechainClientstruct is a necessary addition to facilitate interactions with the distribution module. This change is well-implemented and follows the pattern established by other module-specific query clients in the struct. It ensures that the new distribution-related methods have the required client to make gRPC calls to the blockchain network.- 312-312: Initializing the
distributionQueryClientwithin theNewChainClientfunction is correctly done. This step is crucial for setting up the client with the ability to interact with the distribution module right from the creation of achainClientinstance. The use ofdistributiontypes.NewQueryClient(conn)is consistent with how other module-specific clients are initialized, ensuring uniformity and maintainability.- 1513-1576: The implementation of the distribution module-related methods in the
chainClientstruct is thorough and covers all the functionalities outlined in the PR objectives. Each method correctly constructs the request object, makes the gRPC call using thedistributionQueryClient, and returns the response. This comprehensive implementation enables users of the library to interact with various aspects of the distribution module, enhancing the library's utility for blockchain network interactions. It's also worth noting that the methods are implemented consistently with existing patterns in the codebase, which aids in maintainability.
Comment on lines
6
to
12
| "github.com/cosmos/cosmos-sdk/x/distribution/types" | ||
| "os" | ||
|
|
||
| "github.com/InjectiveLabs/sdk-go/client" | ||
| chainclient "github.com/InjectiveLabs/sdk-go/client/chain" | ||
| "github.com/InjectiveLabs/sdk-go/client/common" | ||
| rpchttp "github.com/cometbft/cometbft/rpc/client/http" |
There was a problem hiding this comment.
Consider organizing imports by grouping standard library imports separately from third-party imports for better readability.
import (
"encoding/json"
"fmt"
"os"
"github.com/cosmos/cosmos-sdk/x/distribution/types"
"github.com/InjectiveLabs/sdk-go/client"
chainclient "github.com/InjectiveLabs/sdk-go/client/chain"
"github.com/InjectiveLabs/sdk-go/client/common"
rpchttp "github.com/cometbft/cometbft/rpc/client/http"
)Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
Suggested change
| "github.com/cosmos/cosmos-sdk/x/distribution/types" | |
| "os" | |
| "github.com/InjectiveLabs/sdk-go/client" | |
| chainclient "github.com/InjectiveLabs/sdk-go/client/chain" | |
| "github.com/InjectiveLabs/sdk-go/client/common" | |
| rpchttp "github.com/cometbft/cometbft/rpc/client/http" | |
| import ( | |
| "encoding/json" | |
| "fmt" | |
| "os" | |
| "github.com/cosmos/cosmos-sdk/x/distribution/types" | |
| "github.com/InjectiveLabs/sdk-go/client" | |
| chainclient "github.com/InjectiveLabs/sdk-go/client/chain" | |
| "github.com/InjectiveLabs/sdk-go/client/common" | |
| rpchttp "github.com/cometbft/cometbft/rpc/client/http" | |
| ) |
Comment on lines
+22
to
+30
| senderAddress, cosmosKeyring, err := chainclient.InitCosmosKeyring( | ||
| os.Getenv("HOME")+"/.injectived", | ||
| "injectived", | ||
| "file", | ||
| "inj-user", | ||
| "12345678", | ||
| "5d386fbdbf11f1141010f81a46b40f94887367562bd33b452bbaa6ce1cd1381e", // keyring will be used if pk not provided | ||
| false, | ||
| ) |
There was a problem hiding this comment.
Hardcoding sensitive information such as the mnemonic and keyring passphrase ("12345678") in the source code is a security risk. Consider using environment variables or secure vaults for sensitive data.
Comment on lines
+66
to
+70
| response, err := chainClient.AsyncBroadcastMsg(msg) | ||
|
|
||
| if err != nil { | ||
| panic(err) | ||
| } |
There was a problem hiding this comment.
Error handling for AsyncBroadcastMsg is done by panicking. While this might be acceptable for an example script, in production code, it's better to handle errors gracefully. Consider logging the error or returning it to the caller.
Comment on lines
6
to
13
| "fmt" | ||
| "github.com/cosmos/cosmos-sdk/types/query" | ||
| "os" | ||
|
|
||
| "github.com/InjectiveLabs/sdk-go/client" | ||
| chainclient "github.com/InjectiveLabs/sdk-go/client/chain" | ||
| "github.com/InjectiveLabs/sdk-go/client/common" | ||
| rpchttp "github.com/cometbft/cometbft/rpc/client/http" |
There was a problem hiding this comment.
Similar to the previous file, consider organizing imports by grouping standard library imports separately from third-party imports for better readability.
import (
"context"
"encoding/json"
"fmt"
"os"
"github.com/cosmos/cosmos-sdk/types/query"
"github.com/InjectiveLabs/sdk-go/client"
chainclient "github.com/InjectiveLabs/sdk-go/client/chain"
"github.com/InjectiveLabs/sdk-go/client/common"
rpchttp "github.com/cometbft/cometbft/rpc/client/http"
)Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
Suggested change
| "fmt" | |
| "github.com/cosmos/cosmos-sdk/types/query" | |
| "os" | |
| "github.com/InjectiveLabs/sdk-go/client" | |
| chainclient "github.com/InjectiveLabs/sdk-go/client/chain" | |
| "github.com/InjectiveLabs/sdk-go/client/common" | |
| rpchttp "github.com/cometbft/cometbft/rpc/client/http" | |
| import ( | |
| "context" | |
| "encoding/json" | |
| "fmt" | |
| "os" | |
| "github.com/cosmos/cosmos-sdk/types/query" | |
| "github.com/InjectiveLabs/sdk-go/client" | |
| chainclient "github.com/InjectiveLabs/sdk-go/client/chain" | |
| "github.com/InjectiveLabs/sdk-go/client/common" | |
| rpchttp "github.com/cometbft/cometbft/rpc/client/http" | |
| ) |
Comment on lines
+23
to
+31
| senderAddress, cosmosKeyring, err := chainclient.InitCosmosKeyring( | ||
| os.Getenv("HOME")+"/.injectived", | ||
| "injectived", | ||
| "file", | ||
| "inj-user", | ||
| "12345678", | ||
| "5d386fbdbf11f1141010f81a46b40f94887367562bd33b452bbaa6ce1cd1381e", // keyring will be used if pk not provided | ||
| false, | ||
| ) |
There was a problem hiding this comment.
The same security concern applies here regarding the hardcoding of sensitive information. Use environment variables or secure vaults instead.
Comment on lines
+16
to
+70
| func main() { | ||
| network := common.LoadNetwork("testnet", "lb") | ||
| tmClient, err := rpchttp.New(network.TmEndpoint, "/websocket") | ||
| if err != nil { | ||
| panic(err) | ||
| } | ||
|
|
||
| senderAddress, cosmosKeyring, err := chainclient.InitCosmosKeyring( | ||
| os.Getenv("HOME")+"/.injectived", | ||
| "injectived", | ||
| "file", | ||
| "inj-user", | ||
| "12345678", | ||
| "5d386fbdbf11f1141010f81a46b40f94887367562bd33b452bbaa6ce1cd1381e", // keyring will be used if pk not provided | ||
| false, | ||
| ) | ||
|
|
||
| if err != nil { | ||
| panic(err) | ||
| } | ||
|
|
||
| clientCtx, err := chainclient.NewClientContext( | ||
| network.ChainId, | ||
| senderAddress.String(), | ||
| cosmosKeyring, | ||
| ) | ||
|
|
||
| if err != nil { | ||
| panic(err) | ||
| } | ||
|
|
||
| clientCtx = clientCtx.WithNodeURI(network.TmEndpoint).WithClient(tmClient) | ||
|
|
||
| chainClient, err := chainclient.NewChainClient( | ||
| clientCtx, | ||
| network, | ||
| common.OptionGasPrices(client.DefaultGasPriceWithDenom), | ||
| ) | ||
|
|
||
| if err != nil { | ||
| panic(err) | ||
| } | ||
|
|
||
| validatorAddress := "injvaloper1jue5dpr9lerjn6wlwtrywxrsenrf28ru89z99z" | ||
| ctx := context.Background() | ||
|
|
||
| res, err := chainClient.FetchValidatorCommission(ctx, validatorAddress) | ||
| if err != nil { | ||
| fmt.Println(err) | ||
| } | ||
|
|
||
| str, _ := json.MarshalIndent(res, "", " ") | ||
| fmt.Print(string(str)) | ||
|
|
||
| } |
There was a problem hiding this comment.
The script for querying validator commission follows the established pattern of initialization and querying. The handling of sensitive information, such as the private key, needs to be securely managed to adhere to security best practices.
- "5d386fbdbf11f1141010f81a46b40f94887367562bd33b452bbaa6ce1cd1381e", // keyring will be used if pk not provided
+ os.Getenv("PRIVATE_KEY"), // keyring will be used if pk not providedCommittable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
Suggested change
| func main() { | |
| network := common.LoadNetwork("testnet", "lb") | |
| tmClient, err := rpchttp.New(network.TmEndpoint, "/websocket") | |
| if err != nil { | |
| panic(err) | |
| } | |
| senderAddress, cosmosKeyring, err := chainclient.InitCosmosKeyring( | |
| os.Getenv("HOME")+"/.injectived", | |
| "injectived", | |
| "file", | |
| "inj-user", | |
| "12345678", | |
| "5d386fbdbf11f1141010f81a46b40f94887367562bd33b452bbaa6ce1cd1381e", // keyring will be used if pk not provided | |
| false, | |
| ) | |
| if err != nil { | |
| panic(err) | |
| } | |
| clientCtx, err := chainclient.NewClientContext( | |
| network.ChainId, | |
| senderAddress.String(), | |
| cosmosKeyring, | |
| ) | |
| if err != nil { | |
| panic(err) | |
| } | |
| clientCtx = clientCtx.WithNodeURI(network.TmEndpoint).WithClient(tmClient) | |
| chainClient, err := chainclient.NewChainClient( | |
| clientCtx, | |
| network, | |
| common.OptionGasPrices(client.DefaultGasPriceWithDenom), | |
| ) | |
| if err != nil { | |
| panic(err) | |
| } | |
| validatorAddress := "injvaloper1jue5dpr9lerjn6wlwtrywxrsenrf28ru89z99z" | |
| ctx := context.Background() | |
| res, err := chainClient.FetchValidatorCommission(ctx, validatorAddress) | |
| if err != nil { | |
| fmt.Println(err) | |
| } | |
| str, _ := json.MarshalIndent(res, "", " ") | |
| fmt.Print(string(str)) | |
| } | |
| func main() { | |
| network := common.LoadNetwork("testnet", "lb") | |
| tmClient, err := rpchttp.New(network.TmEndpoint, "/websocket") | |
| if err != nil { | |
| panic(err) | |
| } | |
| senderAddress, cosmosKeyring, err := chainclient.InitCosmosKeyring( | |
| os.Getenv("HOME")+"/.injectived", | |
| "injectived", | |
| "file", | |
| "inj-user", | |
| "12345678", | |
| os.Getenv("PRIVATE_KEY"), // keyring will be used if pk not provided | |
| false, | |
| ) | |
| if err != nil { | |
| panic(err) | |
| } | |
| clientCtx, err := chainclient.NewClientContext( | |
| network.ChainId, | |
| senderAddress.String(), | |
| cosmosKeyring, | |
| ) | |
| if err != nil { | |
| panic(err) | |
| } | |
| clientCtx = clientCtx.WithNodeURI(network.TmEndpoint).WithClient(tmClient) | |
| chainClient, err := chainclient.NewChainClient( | |
| clientCtx, | |
| network, | |
| common.OptionGasPrices(client.DefaultGasPriceWithDenom), | |
| ) | |
| if err != nil { | |
| panic(err) | |
| } | |
| validatorAddress := "injvaloper1jue5dpr9lerjn6wlwtrywxrsenrf28ru89z99z" | |
| ctx := context.Background() | |
| res, err := chainClient.FetchValidatorCommission(ctx, validatorAddress) | |
| if err != nil { | |
| fmt.Println(err) | |
| } | |
| str, _ := json.MarshalIndent(res, "", " ") | |
| fmt.Print(string(str)) | |
| } |
Comment on lines
+16
to
+70
| func main() { | ||
| network := common.LoadNetwork("testnet", "lb") | ||
| tmClient, err := rpchttp.New(network.TmEndpoint, "/websocket") | ||
| if err != nil { | ||
| panic(err) | ||
| } | ||
|
|
||
| senderAddress, cosmosKeyring, err := chainclient.InitCosmosKeyring( | ||
| os.Getenv("HOME")+"/.injectived", | ||
| "injectived", | ||
| "file", | ||
| "inj-user", | ||
| "12345678", | ||
| "5d386fbdbf11f1141010f81a46b40f94887367562bd33b452bbaa6ce1cd1381e", // keyring will be used if pk not provided | ||
| false, | ||
| ) | ||
|
|
||
| if err != nil { | ||
| panic(err) | ||
| } | ||
|
|
||
| clientCtx, err := chainclient.NewClientContext( | ||
| network.ChainId, | ||
| senderAddress.String(), | ||
| cosmosKeyring, | ||
| ) | ||
|
|
||
| if err != nil { | ||
| panic(err) | ||
| } | ||
|
|
||
| clientCtx = clientCtx.WithNodeURI(network.TmEndpoint).WithClient(tmClient) | ||
|
|
||
| chainClient, err := chainclient.NewChainClient( | ||
| clientCtx, | ||
| network, | ||
| common.OptionGasPrices(client.DefaultGasPriceWithDenom), | ||
| ) | ||
|
|
||
| if err != nil { | ||
| panic(err) | ||
| } | ||
|
|
||
| validatorAddress := "injvaloper1jue5dpr9lerjn6wlwtrywxrsenrf28ru89z99z" | ||
| ctx := context.Background() | ||
|
|
||
| res, err := chainClient.FetchValidatorDistributionInfo(ctx, validatorAddress) | ||
| if err != nil { | ||
| fmt.Println(err) | ||
| } | ||
|
|
||
| str, _ := json.MarshalIndent(res, "", " ") | ||
| fmt.Print(string(str)) | ||
|
|
||
| } |
There was a problem hiding this comment.
The example script for querying validator distribution info is consistent with the patterns observed in previous files. The recommendation regarding the secure handling of sensitive information, such as the private key, remains critically important.
- "5d386fbdbf11f1141010f81a46b40f94887367562bd33b452bbaa6ce1cd1381e", // keyring will be used if pk not provided
+ os.Getenv("PRIVATE_KEY"), // keyring will be used if pk not providedCommittable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
Suggested change
| func main() { | |
| network := common.LoadNetwork("testnet", "lb") | |
| tmClient, err := rpchttp.New(network.TmEndpoint, "/websocket") | |
| if err != nil { | |
| panic(err) | |
| } | |
| senderAddress, cosmosKeyring, err := chainclient.InitCosmosKeyring( | |
| os.Getenv("HOME")+"/.injectived", | |
| "injectived", | |
| "file", | |
| "inj-user", | |
| "12345678", | |
| "5d386fbdbf11f1141010f81a46b40f94887367562bd33b452bbaa6ce1cd1381e", // keyring will be used if pk not provided | |
| false, | |
| ) | |
| if err != nil { | |
| panic(err) | |
| } | |
| clientCtx, err := chainclient.NewClientContext( | |
| network.ChainId, | |
| senderAddress.String(), | |
| cosmosKeyring, | |
| ) | |
| if err != nil { | |
| panic(err) | |
| } | |
| clientCtx = clientCtx.WithNodeURI(network.TmEndpoint).WithClient(tmClient) | |
| chainClient, err := chainclient.NewChainClient( | |
| clientCtx, | |
| network, | |
| common.OptionGasPrices(client.DefaultGasPriceWithDenom), | |
| ) | |
| if err != nil { | |
| panic(err) | |
| } | |
| validatorAddress := "injvaloper1jue5dpr9lerjn6wlwtrywxrsenrf28ru89z99z" | |
| ctx := context.Background() | |
| res, err := chainClient.FetchValidatorDistributionInfo(ctx, validatorAddress) | |
| if err != nil { | |
| fmt.Println(err) | |
| } | |
| str, _ := json.MarshalIndent(res, "", " ") | |
| fmt.Print(string(str)) | |
| } | |
| func main() { | |
| network := common.LoadNetwork("testnet", "lb") | |
| tmClient, err := rpchttp.New(network.TmEndpoint, "/websocket") | |
| if err != nil { | |
| panic(err) | |
| } | |
| senderAddress, cosmosKeyring, err := chainclient.InitCosmosKeyring( | |
| os.Getenv("HOME")+"/.injectived", | |
| "injectived", | |
| "file", | |
| "inj-user", | |
| "12345678", | |
| os.Getenv("PRIVATE_KEY"), // keyring will be used if pk not provided | |
| false, | |
| ) | |
| if err != nil { | |
| panic(err) | |
| } | |
| clientCtx, err := chainclient.NewClientContext( | |
| network.ChainId, | |
| senderAddress.String(), | |
| cosmosKeyring, | |
| ) | |
| if err != nil { | |
| panic(err) | |
| } | |
| clientCtx = clientCtx.WithNodeURI(network.TmEndpoint).WithClient(tmClient) | |
| chainClient, err := chainclient.NewChainClient( | |
| clientCtx, | |
| network, | |
| common.OptionGasPrices(client.DefaultGasPriceWithDenom), | |
| ) | |
| if err != nil { | |
| panic(err) | |
| } | |
| validatorAddress := "injvaloper1jue5dpr9lerjn6wlwtrywxrsenrf28ru89z99z" | |
| ctx := context.Background() | |
| res, err := chainClient.FetchValidatorDistributionInfo(ctx, validatorAddress) | |
| if err != nil { | |
| fmt.Println(err) | |
| } | |
| str, _ := json.MarshalIndent(res, "", " ") | |
| fmt.Print(string(str)) | |
| } |
Comment on lines
+16
to
+70
| func main() { | ||
| network := common.LoadNetwork("testnet", "lb") | ||
| tmClient, err := rpchttp.New(network.TmEndpoint, "/websocket") | ||
| if err != nil { | ||
| panic(err) | ||
| } | ||
|
|
||
| senderAddress, cosmosKeyring, err := chainclient.InitCosmosKeyring( | ||
| os.Getenv("HOME")+"/.injectived", | ||
| "injectived", | ||
| "file", | ||
| "inj-user", | ||
| "12345678", | ||
| "5d386fbdbf11f1141010f81a46b40f94887367562bd33b452bbaa6ce1cd1381e", // keyring will be used if pk not provided | ||
| false, | ||
| ) | ||
|
|
||
| if err != nil { | ||
| panic(err) | ||
| } | ||
|
|
||
| clientCtx, err := chainclient.NewClientContext( | ||
| network.ChainId, | ||
| senderAddress.String(), | ||
| cosmosKeyring, | ||
| ) | ||
|
|
||
| if err != nil { | ||
| panic(err) | ||
| } | ||
|
|
||
| clientCtx = clientCtx.WithNodeURI(network.TmEndpoint).WithClient(tmClient) | ||
|
|
||
| chainClient, err := chainclient.NewChainClient( | ||
| clientCtx, | ||
| network, | ||
| common.OptionGasPrices(client.DefaultGasPriceWithDenom), | ||
| ) | ||
|
|
||
| if err != nil { | ||
| panic(err) | ||
| } | ||
|
|
||
| validatorAddress := "injvaloper1jue5dpr9lerjn6wlwtrywxrsenrf28ru89z99z" | ||
| ctx := context.Background() | ||
|
|
||
| res, err := chainClient.FetchValidatorOutstandingRewards(ctx, validatorAddress) | ||
| if err != nil { | ||
| fmt.Println(err) | ||
| } | ||
|
|
||
| str, _ := json.MarshalIndent(res, "", " ") | ||
| fmt.Print(string(str)) | ||
|
|
||
| } |
There was a problem hiding this comment.
The script for querying validator outstanding rewards follows the established pattern of initialization and querying. The handling of sensitive information, such as the private key, needs to be securely managed to adhere to security best practices.
- "5d386fbdbf11f1141010f81a46b40f94887367562bd33b452bbaa6ce1cd1381e", // keyring will be used if pk not provided
+ os.Getenv("PRIVATE_KEY"), // keyring will be used if pk not providedCommittable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
Suggested change
| func main() { | |
| network := common.LoadNetwork("testnet", "lb") | |
| tmClient, err := rpchttp.New(network.TmEndpoint, "/websocket") | |
| if err != nil { | |
| panic(err) | |
| } | |
| senderAddress, cosmosKeyring, err := chainclient.InitCosmosKeyring( | |
| os.Getenv("HOME")+"/.injectived", | |
| "injectived", | |
| "file", | |
| "inj-user", | |
| "12345678", | |
| "5d386fbdbf11f1141010f81a46b40f94887367562bd33b452bbaa6ce1cd1381e", // keyring will be used if pk not provided | |
| false, | |
| ) | |
| if err != nil { | |
| panic(err) | |
| } | |
| clientCtx, err := chainclient.NewClientContext( | |
| network.ChainId, | |
| senderAddress.String(), | |
| cosmosKeyring, | |
| ) | |
| if err != nil { | |
| panic(err) | |
| } | |
| clientCtx = clientCtx.WithNodeURI(network.TmEndpoint).WithClient(tmClient) | |
| chainClient, err := chainclient.NewChainClient( | |
| clientCtx, | |
| network, | |
| common.OptionGasPrices(client.DefaultGasPriceWithDenom), | |
| ) | |
| if err != nil { | |
| panic(err) | |
| } | |
| validatorAddress := "injvaloper1jue5dpr9lerjn6wlwtrywxrsenrf28ru89z99z" | |
| ctx := context.Background() | |
| res, err := chainClient.FetchValidatorOutstandingRewards(ctx, validatorAddress) | |
| if err != nil { | |
| fmt.Println(err) | |
| } | |
| str, _ := json.MarshalIndent(res, "", " ") | |
| fmt.Print(string(str)) | |
| } | |
| func main() { | |
| network := common.LoadNetwork("testnet", "lb") | |
| tmClient, err := rpchttp.New(network.TmEndpoint, "/websocket") | |
| if err != nil { | |
| panic(err) | |
| } | |
| senderAddress, cosmosKeyring, err := chainclient.InitCosmosKeyring( | |
| os.Getenv("HOME")+"/.injectived", | |
| "injectived", | |
| "file", | |
| "inj-user", | |
| "12345678", | |
| os.Getenv("PRIVATE_KEY"), // keyring will be used if pk not provided | |
| false, | |
| ) | |
| if err != nil { | |
| panic(err) | |
| } | |
| clientCtx, err := chainclient.NewClientContext( | |
| network.ChainId, | |
| senderAddress.String(), | |
| cosmosKeyring, | |
| ) | |
| if err != nil { | |
| panic(err) | |
| } | |
| clientCtx = clientCtx.WithNodeURI(network.TmEndpoint).WithClient(tmClient) | |
| chainClient, err := chainclient.NewChainClient( | |
| clientCtx, | |
| network, | |
| common.OptionGasPrices(client.DefaultGasPriceWithDenom), | |
| ) | |
| if err != nil { | |
| panic(err) | |
| } | |
| validatorAddress := "injvaloper1jue5dpr9lerjn6wlwtrywxrsenrf28ru89z99z" | |
| ctx := context.Background() | |
| res, err := chainClient.FetchValidatorOutstandingRewards(ctx, validatorAddress) | |
| if err != nil { | |
| fmt.Println(err) | |
| } | |
| str, _ := json.MarshalIndent(res, "", " ") | |
| fmt.Print(string(str)) | |
| } |
Comment on lines
+16
to
+71
| func main() { | ||
| network := common.LoadNetwork("testnet", "lb") | ||
| tmClient, err := rpchttp.New(network.TmEndpoint, "/websocket") | ||
| if err != nil { | ||
| panic(err) | ||
| } | ||
|
|
||
| senderAddress, cosmosKeyring, err := chainclient.InitCosmosKeyring( | ||
| os.Getenv("HOME")+"/.injectived", | ||
| "injectived", | ||
| "file", | ||
| "inj-user", | ||
| "12345678", | ||
| "5d386fbdbf11f1141010f81a46b40f94887367562bd33b452bbaa6ce1cd1381e", // keyring will be used if pk not provided | ||
| false, | ||
| ) | ||
|
|
||
| if err != nil { | ||
| panic(err) | ||
| } | ||
|
|
||
| clientCtx, err := chainclient.NewClientContext( | ||
| network.ChainId, | ||
| senderAddress.String(), | ||
| cosmosKeyring, | ||
| ) | ||
|
|
||
| if err != nil { | ||
| panic(err) | ||
| } | ||
|
|
||
| clientCtx = clientCtx.WithNodeURI(network.TmEndpoint).WithClient(tmClient) | ||
|
|
||
| chainClient, err := chainclient.NewChainClient( | ||
| clientCtx, | ||
| network, | ||
| common.OptionGasPrices(client.DefaultGasPriceWithDenom), | ||
| ) | ||
|
|
||
| if err != nil { | ||
| panic(err) | ||
| } | ||
|
|
||
| delegatorAddress := "inj1hkhdaj2a2clmq5jq6mspsggqs32vynpk228q3r" | ||
| validatorAddress := "injvaloper156t3yxd4udv0h9gwagfcmwnmm3quy0nph7tyh5" | ||
| ctx := context.Background() | ||
|
|
||
| res, err := chainClient.FetchDelegationRewards(ctx, delegatorAddress, validatorAddress) | ||
| if err != nil { | ||
| fmt.Println(err) | ||
| } | ||
|
|
||
| str, _ := json.MarshalIndent(res, "", " ") | ||
| fmt.Print(string(str)) | ||
|
|
||
| } |
There was a problem hiding this comment.
The example script for querying delegation rewards is consistent with the patterns observed in previous files. The recommendation regarding the secure handling of sensitive information, such as the private key, remains critically important.
- "5d386fbdbf11f1141010f81a46b40f94887367562bd33b452bbaa6ce1cd1381e", // keyring will be used if pk not provided
+ os.Getenv("PRIVATE_KEY"), // keyring will be used if pk not providedCommittable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
Suggested change
| func main() { | |
| network := common.LoadNetwork("testnet", "lb") | |
| tmClient, err := rpchttp.New(network.TmEndpoint, "/websocket") | |
| if err != nil { | |
| panic(err) | |
| } | |
| senderAddress, cosmosKeyring, err := chainclient.InitCosmosKeyring( | |
| os.Getenv("HOME")+"/.injectived", | |
| "injectived", | |
| "file", | |
| "inj-user", | |
| "12345678", | |
| "5d386fbdbf11f1141010f81a46b40f94887367562bd33b452bbaa6ce1cd1381e", // keyring will be used if pk not provided | |
| false, | |
| ) | |
| if err != nil { | |
| panic(err) | |
| } | |
| clientCtx, err := chainclient.NewClientContext( | |
| network.ChainId, | |
| senderAddress.String(), | |
| cosmosKeyring, | |
| ) | |
| if err != nil { | |
| panic(err) | |
| } | |
| clientCtx = clientCtx.WithNodeURI(network.TmEndpoint).WithClient(tmClient) | |
| chainClient, err := chainclient.NewChainClient( | |
| clientCtx, | |
| network, | |
| common.OptionGasPrices(client.DefaultGasPriceWithDenom), | |
| ) | |
| if err != nil { | |
| panic(err) | |
| } | |
| delegatorAddress := "inj1hkhdaj2a2clmq5jq6mspsggqs32vynpk228q3r" | |
| validatorAddress := "injvaloper156t3yxd4udv0h9gwagfcmwnmm3quy0nph7tyh5" | |
| ctx := context.Background() | |
| res, err := chainClient.FetchDelegationRewards(ctx, delegatorAddress, validatorAddress) | |
| if err != nil { | |
| fmt.Println(err) | |
| } | |
| str, _ := json.MarshalIndent(res, "", " ") | |
| fmt.Print(string(str)) | |
| } | |
| func main() { | |
| network := common.LoadNetwork("testnet", "lb") | |
| tmClient, err := rpchttp.New(network.TmEndpoint, "/websocket") | |
| if err != nil { | |
| panic(err) | |
| } | |
| senderAddress, cosmosKeyring, err := chainclient.InitCosmosKeyring( | |
| os.Getenv("HOME")+"/.injectived", | |
| "injectived", | |
| "file", | |
| "inj-user", | |
| "12345678", | |
| os.Getenv("PRIVATE_KEY"), // keyring will be used if pk not provided | |
| false, | |
| ) | |
| if err != nil { | |
| panic(err) | |
| } | |
| clientCtx, err := chainclient.NewClientContext( | |
| network.ChainId, | |
| senderAddress.String(), | |
| cosmosKeyring, | |
| ) | |
| if err != nil { | |
| panic(err) | |
| } | |
| clientCtx = clientCtx.WithNodeURI(network.TmEndpoint).WithClient(tmClient) | |
| chainClient, err := chainclient.NewChainClient( | |
| clientCtx, | |
| network, | |
| common.OptionGasPrices(client.DefaultGasPriceWithDenom), | |
| ) | |
| if err != nil { | |
| panic(err) | |
| } | |
| delegatorAddress := "inj1hkhdaj2a2clmq5jq6mspsggqs32vynpk228q3r" | |
| validatorAddress := "injvaloper156t3yxd4udv0h9gwagfcmwnmm3quy0nph7tyh5" | |
| ctx := context.Background() | |
| res, err := chainClient.FetchDelegationRewards(ctx, delegatorAddress, validatorAddress) | |
| if err != nil { | |
| fmt.Println(err) | |
| } | |
| str, _ := json.MarshalIndent(res, "", " ") | |
| fmt.Print(string(str)) | |
| } |
Comment on lines
+16
to
+73
| network := common.LoadNetwork("testnet", "lb") | ||
| tmClient, err := rpchttp.New(network.TmEndpoint, "/websocket") | ||
| if err != nil { | ||
| panic(err) | ||
| } | ||
|
|
||
| senderAddress, cosmosKeyring, err := chainclient.InitCosmosKeyring( | ||
| os.Getenv("HOME")+"/.injectived", | ||
| "injectived", | ||
| "file", | ||
| "inj-user", | ||
| "12345678", | ||
| "5d386fbdbf11f1141010f81a46b40f94887367562bd33b452bbaa6ce1cd1381e", // keyring will be used if pk not provided | ||
| false, | ||
| ) | ||
|
|
||
| if err != nil { | ||
| panic(err) | ||
| } | ||
|
|
||
| clientCtx, err := chainclient.NewClientContext( | ||
| network.ChainId, | ||
| senderAddress.String(), | ||
| cosmosKeyring, | ||
| ) | ||
|
|
||
| if err != nil { | ||
| panic(err) | ||
| } | ||
|
|
||
| clientCtx = clientCtx.WithNodeURI(network.TmEndpoint).WithClient(tmClient) | ||
|
|
||
| chainClient, err := chainclient.NewChainClient( | ||
| clientCtx, | ||
| network, | ||
| common.OptionGasPrices(client.DefaultGasPriceWithDenom), | ||
| ) | ||
|
|
||
| if err != nil { | ||
| panic(err) | ||
| } | ||
|
|
||
| validatorAddress := "injvaloper1ultw9r29l8nxy5u6thcgusjn95vsy2caw722q5" | ||
|
|
||
| msg := &types.MsgWithdrawValidatorCommission{ | ||
| ValidatorAddress: validatorAddress, | ||
| } | ||
|
|
||
| //AsyncBroadcastMsg, SyncBroadcastMsg, QueueBroadcastMsg | ||
| response, err := chainClient.AsyncBroadcastMsg(msg) | ||
|
|
||
| if err != nil { | ||
| panic(err) | ||
| } | ||
|
|
||
| str, _ := json.MarshalIndent(response, "", " ") | ||
| fmt.Print(string(str)) | ||
| } |
There was a problem hiding this comment.
The script for withdrawing validator commission is well-structured and demonstrates the transaction broadcast process effectively. As with previous scripts, ensure that sensitive information, such as the private key, is securely managed and not hardcoded.
- "5d386fbdbf11f1141010f81a46b40f94887367562bd33b452bbaa6ce1cd1381e", // keyring will be used if pk not provided
+ os.Getenv("PRIVATE_KEY"), // keyring will be used if pk not providedCommittable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
Suggested change
| network := common.LoadNetwork("testnet", "lb") | |
| tmClient, err := rpchttp.New(network.TmEndpoint, "/websocket") | |
| if err != nil { | |
| panic(err) | |
| } | |
| senderAddress, cosmosKeyring, err := chainclient.InitCosmosKeyring( | |
| os.Getenv("HOME")+"/.injectived", | |
| "injectived", | |
| "file", | |
| "inj-user", | |
| "12345678", | |
| "5d386fbdbf11f1141010f81a46b40f94887367562bd33b452bbaa6ce1cd1381e", // keyring will be used if pk not provided | |
| false, | |
| ) | |
| if err != nil { | |
| panic(err) | |
| } | |
| clientCtx, err := chainclient.NewClientContext( | |
| network.ChainId, | |
| senderAddress.String(), | |
| cosmosKeyring, | |
| ) | |
| if err != nil { | |
| panic(err) | |
| } | |
| clientCtx = clientCtx.WithNodeURI(network.TmEndpoint).WithClient(tmClient) | |
| chainClient, err := chainclient.NewChainClient( | |
| clientCtx, | |
| network, | |
| common.OptionGasPrices(client.DefaultGasPriceWithDenom), | |
| ) | |
| if err != nil { | |
| panic(err) | |
| } | |
| validatorAddress := "injvaloper1ultw9r29l8nxy5u6thcgusjn95vsy2caw722q5" | |
| msg := &types.MsgWithdrawValidatorCommission{ | |
| ValidatorAddress: validatorAddress, | |
| } | |
| //AsyncBroadcastMsg, SyncBroadcastMsg, QueueBroadcastMsg | |
| response, err := chainClient.AsyncBroadcastMsg(msg) | |
| if err != nil { | |
| panic(err) | |
| } | |
| str, _ := json.MarshalIndent(response, "", " ") | |
| fmt.Print(string(str)) | |
| } | |
| network := common.LoadNetwork("testnet", "lb") | |
| tmClient, err := rpchttp.New(network.TmEndpoint, "/websocket") | |
| if err != nil { | |
| panic(err) | |
| } | |
| senderAddress, cosmosKeyring, err := chainclient.InitCosmosKeyring( | |
| os.Getenv("HOME")+"/.injectived", | |
| "injectived", | |
| "file", | |
| "inj-user", | |
| "12345678", | |
| os.Getenv("PRIVATE_KEY"), // keyring will be used if pk not provided | |
| false, | |
| ) | |
| if err != nil { | |
| panic(err) | |
| } | |
| clientCtx, err := chainclient.NewClientContext( | |
| network.ChainId, | |
| senderAddress.String(), | |
| cosmosKeyring, | |
| ) | |
| if err != nil { | |
| panic(err) | |
| } | |
| clientCtx = clientCtx.WithNodeURI(network.TmEndpoint).WithClient(tmClient) | |
| chainClient, err := chainclient.NewChainClient( | |
| clientCtx, | |
| network, | |
| common.OptionGasPrices(client.DefaultGasPriceWithDenom), | |
| ) | |
| if err != nil { | |
| panic(err) | |
| } | |
| validatorAddress := "injvaloper1ultw9r29l8nxy5u6thcgusjn95vsy2caw722q5" | |
| msg := &types.MsgWithdrawValidatorCommission{ | |
| ValidatorAddress: validatorAddress, | |
| } | |
| //AsyncBroadcastMsg, SyncBroadcastMsg, QueueBroadcastMsg | |
| response, err := chainClient.AsyncBroadcastMsg(msg) | |
| if err != nil { | |
| panic(err) | |
| } | |
| str, _ := json.MarshalIndent(response, "", " ") | |
| fmt.Print(string(str)) | |
| } |
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: .coderabbit.yaml
Files selected for processing (6)
- client/chain/chain.go (5 hunks)
- client/chain/chain_test_support.go (2 hunks)
- examples/chain/distribution/1_SetWithdrawAddress/example.go (1 hunks)
- examples/chain/distribution/3_WithdrawValidatorCommission/example.go (1 hunks)
- examples/chain/distribution/4_FundCommunityPool/example.go (1 hunks)
- examples/chain/distribution/query/4_ValidatorSlashes/example.go (1 hunks)
Files skipped from review as they are similar to previous changes (6)
- client/chain/chain.go
- client/chain/chain_test_support.go
- examples/chain/distribution/1_SetWithdrawAddress/example.go
- examples/chain/distribution/3_WithdrawValidatorCommission/example.go
- examples/chain/distribution/4_FundCommunityPool/example.go
- examples/chain/distribution/query/4_ValidatorSlashes/example.go
nicolasbaum
approved these changes
Mar 5, 2024
nicolasbaum
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
distributionmodule.Summary by CodeRabbit
ChainClientinterface to include distribution module methods for blockchain interactions.