Feat/update dependencies chain v1 13 #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ll go.mod dependencies to sync with injective-core dependencies
|
Caution Review failedThe pull request is closed. WalkthroughThe recent changes enhance the flexibility and maintainability of a Cosmos SDK application by updating various workflows and configuration files. Enhancements include adopting dynamic Go version management, improving codec registrations, and refining error handling for permissions. These modifications streamline the build process, bolster testing capabilities, and enhance context management in keeper interfaces, paving the way for a more robust and adaptable application. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Application
participant Codec
participant Keeper
User->>Application: Initiate action
Application->>Codec: Serialize request
Codec->>Application: Return serialized data
Application->>Keeper: Execute operation
Keeper->>Application: Return result
Application->>User: Send response
TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
…use from the go.mod file
… that makes the workflow fail
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #224 +/- ##
==========================================
- Coverage 20.97% 15.77% -5.20%
==========================================
Files 18 25 +7
Lines 3614 4722 +1108
==========================================
- Hits 758 745 -13
- Misses 2828 3946 +1118
- Partials 28 31 +3 ☔ View full report in Codecov by Sentry. |
…ll go.mod dependencies to sync with injective-core dependencies
…use from the go.mod file
… that makes the workflow fail
….com/InjectiveLabs/sdk-go into feat/update_dependencies_chain_v1_13
hmoragrega
reviewed
Jun 10, 2024
Comment on lines
+977
to
+981
| MinNotional cosmossdk_io_math.LegacyDec `protobuf:"bytes,11,opt,name=min_notional,json=minNotional,proto3,customtype=cosmossdk.io/math.LegacyDec" json:"min_notional"` | ||
| // current market admin | ||
| Admin string `protobuf:"bytes,12,opt,name=admin,proto3" json:"admin,omitempty"` | ||
| // level of admin permissions | ||
| AdminPermissions uint32 `protobuf:"varint,13,opt,name=admin_permissions,json=adminPermissions,proto3" json:"admin_permissions,omitempty"` |
There was a problem hiding this comment.
these looks like new fields in the events @proofofze
| OrderHash []byte `protobuf:"bytes,5,opt,name=order_hash,json=orderHash,proto3" json:"order_hash,omitempty"` | ||
| FeeRecipientAddress []byte `protobuf:"bytes,6,opt,name=fee_recipient_address,json=feeRecipientAddress,proto3" json:"fee_recipient_address,omitempty"` | ||
| Cid string `protobuf:"bytes,7,opt,name=cid,proto3" json:"cid,omitempty"` | ||
| Pnl cosmossdk_io_math.LegacyDec `protobuf:"bytes,8,opt,name=pnl,proto3,customtype=cosmossdk.io/math.LegacyDec" json:"pnl"` |
There was a problem hiding this comment.
the famous PNL 🥲 @proofofze
…ermissions module's messages and queries
… indexer. Updated example scripts
proofofze
force-pushed
the
feat/update_dependencies_chain_v1_13
branch
from
c35ed22
to
c644192
Compare
….com/InjectiveLabs/sdk-go into feat/update_dependencies_chain_v1_13
fix: make PrepareFactory public so chilliass can re-use it
…e and injective-indexer (v1.13 chain upgrade candidates)
…ermissions module's messages and queries
…/InjectiveLabs/sdk-go into feat/permissions_module_messages
…ssages Feat/permissions module messages
…ript. Updated all markets and tokens INI files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will remain a draft until the Indexer version for the chain upgrade to v1.13
Solves CHAIN-109
Summary by CodeRabbit
New Features
MsgBlacklistEthereumAddresses,MsgRevokeEthereumBlacklist), enhancing security capabilities.Improvements
Bug Fixes
Documentation