Skip to content

Commit e4beb6e

Browse files
authored
Merge pull request #266 from InjectiveLabs/fix/add_missing_parameters_in_spot_and_deriv_messages
Fix/add missing parameters in spot and deriv messages
2 parents 05505fe + 96e7f4c commit e4beb6e

File tree

5 files changed

+197
-133
lines changed

5 files changed

+197
-133
lines changed

pyinjective/async_client.py

Lines changed: 83 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -515,40 +515,57 @@ async def get_spot_orders(self, market_id: str, **kwargs):
515515
subaccount_id=kwargs.get("subaccount_id"),
516516
skip=kwargs.get("skip"),
517517
limit=kwargs.get("limit"),
518+
start_time=kwargs.get("start_time"),
519+
end_time=kwargs.get("end_time"),
520+
market_ids=kwargs.get("market_ids"),
521+
include_inactive=kwargs.get("include_inactive"),
522+
subaccount_total_orders=kwargs.get("subaccount_total_orders"),
523+
trade_id=kwargs.get("trade_id"),
524+
cid=kwargs.get("cid"),
518525
)
519526
return await self.stubSpotExchange.Orders(req)
520527

521528
async def get_historical_spot_orders(self, market_id: Optional[str] = None, **kwargs):
522529
market_ids = kwargs.get("market_ids", [])
523530
if market_id is not None:
524531
market_ids.append(market_id)
532+
order_types = kwargs.get("order_types", [])
533+
order_type = kwargs.get("order_type")
534+
if order_type is not None:
535+
order_types.append(market_id)
525536
req = spot_exchange_rpc_pb.OrdersHistoryRequest(
526-
market_ids=kwargs.get("market_ids", []),
527-
direction=kwargs.get("direction"),
528-
order_types=kwargs.get("order_types", []),
529-
execution_types=kwargs.get("execution_types", []),
530537
subaccount_id=kwargs.get("subaccount_id"),
531538
skip=kwargs.get("skip"),
532539
limit=kwargs.get("limit"),
540+
order_types=order_types,
541+
direction=kwargs.get("direction"),
533542
start_time=kwargs.get("start_time"),
534543
end_time=kwargs.get("end_time"),
535544
state=kwargs.get("state"),
545+
execution_types=kwargs.get("execution_types", []),
546+
market_ids=market_ids,
547+
trade_id=kwargs.get("trade_id"),
548+
active_markets_only=kwargs.get("active_markets_only"),
549+
cid=kwargs.get("cid"),
536550
)
537551
return await self.stubSpotExchange.OrdersHistory(req)
538552

539553
async def get_spot_trades(self, **kwargs):
540554
req = spot_exchange_rpc_pb.TradesRequest(
541555
market_id=kwargs.get("market_id"),
542-
market_ids=kwargs.get("market_ids"),
543556
execution_side=kwargs.get("execution_side"),
544557
direction=kwargs.get("direction"),
545558
subaccount_id=kwargs.get("subaccount_id"),
546-
subaccount_ids=kwargs.get("subaccount_ids"),
547559
skip=kwargs.get("skip"),
548560
limit=kwargs.get("limit"),
549561
start_time=kwargs.get("start_time"),
550562
end_time=kwargs.get("end_time"),
563+
market_ids=kwargs.get("market_ids"),
564+
subaccount_ids=kwargs.get("subaccount_ids"),
551565
execution_types=kwargs.get("execution_types"),
566+
trade_id=kwargs.get("trade_id"),
567+
account_address=kwargs.get("account_address"),
568+
cid=kwargs.get("cid"),
552569
)
553570
return await self.stubSpotExchange.Trades(req)
554571

@@ -571,6 +588,15 @@ async def stream_spot_orders(self, market_id: str, **kwargs):
571588
market_id=market_id,
572589
order_side=kwargs.get("order_side"),
573590
subaccount_id=kwargs.get("subaccount_id"),
591+
skip=kwargs.get("skip"),
592+
limit=kwargs.get("limit"),
593+
start_time=kwargs.get("start_time"),
594+
end_time=kwargs.get("end_time"),
595+
market_ids=kwargs.get("market_ids"),
596+
include_inactive=kwargs.get("include_inactive"),
597+
subaccount_total_orders=kwargs.get("subaccount_total_orders"),
598+
trade_id=kwargs.get("trade_id"),
599+
cid=kwargs.get("cid"),
574600
)
575601
metadata = await self.network.exchange_metadata(
576602
metadata_query_provider=self._exchange_cookie_metadata_requestor
@@ -608,12 +634,19 @@ async def stream_historical_derivative_orders(self, market_id: str, **kwargs):
608634
async def stream_spot_trades(self, **kwargs):
609635
req = spot_exchange_rpc_pb.StreamTradesRequest(
610636
market_id=kwargs.get("market_id"),
611-
market_ids=kwargs.get("market_ids"),
612637
execution_side=kwargs.get("execution_side"),
613638
direction=kwargs.get("direction"),
614639
subaccount_id=kwargs.get("subaccount_id"),
640+
skip=kwargs.get("skip"),
641+
limit=kwargs.get("limit"),
642+
start_time=kwargs.get("start_time"),
643+
end_time=kwargs.get("end_time"),
644+
market_ids=kwargs.get("market_ids"),
615645
subaccount_ids=kwargs.get("subaccount_ids"),
616646
execution_types=kwargs.get("execution_types"),
647+
trade_id=kwargs.get("trade_id"),
648+
account_address=kwargs.get("account_address"),
649+
cid=kwargs.get("cid"),
617650
)
618651
metadata = await self.network.exchange_metadata(
619652
metadata_query_provider=self._exchange_cookie_metadata_requestor
@@ -679,6 +712,15 @@ async def get_derivative_orders(self, market_id: str, **kwargs):
679712
subaccount_id=kwargs.get("subaccount_id"),
680713
skip=kwargs.get("skip"),
681714
limit=kwargs.get("limit"),
715+
start_time=kwargs.get("start_time"),
716+
end_time=kwargs.get("end_time"),
717+
market_ids=kwargs.get("market_ids"),
718+
is_conditional=kwargs.get("is_conditional"),
719+
order_type=kwargs.get("order_type"),
720+
include_inactive=kwargs.get("include_inactive"),
721+
subaccount_total_orders=kwargs.get("subaccount_total_orders"),
722+
trade_id=kwargs.get("trade_id"),
723+
cid=kwargs.get("cid"),
682724
)
683725
return await self.stubDerivativeExchange.Orders(req)
684726

@@ -691,33 +733,39 @@ async def get_historical_derivative_orders(self, market_id: Optional[str] = None
691733
if order_type is not None:
692734
order_types.append(market_id)
693735
req = derivative_exchange_rpc_pb.OrdersHistoryRequest(
694-
market_ids=market_ids,
695-
direction=kwargs.get("direction"),
696-
order_types=order_types,
697-
execution_types=kwargs.get("execution_types", []),
698736
subaccount_id=kwargs.get("subaccount_id"),
699-
is_conditional=kwargs.get("is_conditional"),
700737
skip=kwargs.get("skip"),
701738
limit=kwargs.get("limit"),
739+
order_types=order_types,
740+
direction=kwargs.get("direction"),
702741
start_time=kwargs.get("start_time"),
703742
end_time=kwargs.get("end_time"),
743+
is_conditional=kwargs.get("is_conditional"),
704744
state=kwargs.get("state"),
745+
execution_types=kwargs.get("execution_types", []),
746+
market_ids=market_ids,
747+
trade_id=kwargs.get("trade_id"),
748+
active_markets_only=kwargs.get("active_markets_only"),
749+
cid=kwargs.get("cid"),
705750
)
706751
return await self.stubDerivativeExchange.OrdersHistory(req)
707752

708753
async def get_derivative_trades(self, **kwargs):
709754
req = derivative_exchange_rpc_pb.TradesRequest(
710755
market_id=kwargs.get("market_id"),
711-
market_ids=kwargs.get("market_ids"),
712-
subaccount_id=kwargs.get("subaccount_id"),
713-
subaccount_ids=kwargs.get("subaccount_ids"),
714756
execution_side=kwargs.get("execution_side"),
715757
direction=kwargs.get("direction"),
758+
subaccount_id=kwargs.get("subaccount_id"),
716759
skip=kwargs.get("skip"),
717760
limit=kwargs.get("limit"),
718761
start_time=kwargs.get("start_time"),
719762
end_time=kwargs.get("end_time"),
763+
market_ids=kwargs.get("market_ids"),
764+
subaccount_ids=kwargs.get("subaccount_ids"),
720765
execution_types=kwargs.get("execution_types"),
766+
trade_id=kwargs.get("trade_id"),
767+
account_address=kwargs.get("account_address"),
768+
cid=kwargs.get("cid"),
721769
)
722770
return await self.stubDerivativeExchange.Trades(req)
723771

@@ -738,8 +786,19 @@ async def stream_derivative_orderbook_update(self, market_ids: List[str]):
738786
async def stream_derivative_orders(self, market_id: str, **kwargs):
739787
req = derivative_exchange_rpc_pb.StreamOrdersRequest(
740788
market_id=market_id,
741-
order_side=kwargs.get("order_side"),
789+
execution_side=kwargs.get("execution_side"),
790+
direction=kwargs.get("direction"),
742791
subaccount_id=kwargs.get("subaccount_id"),
792+
skip=kwargs.get("skip"),
793+
limit=kwargs.get("limit"),
794+
start_time=kwargs.get("start_time"),
795+
end_time=kwargs.get("end_time"),
796+
market_ids=kwargs.get("market_ids"),
797+
subaccount_ids=kwargs.get("subaccount_ids"),
798+
execution_types=kwargs.get("execution_types"),
799+
trade_id=kwargs.get("trade_id"),
800+
account_address=kwargs.get("account_address"),
801+
cid=kwargs.get("cid"),
743802
)
744803
metadata = await self.network.exchange_metadata(
745804
metadata_query_provider=self._exchange_cookie_metadata_requestor
@@ -749,14 +808,19 @@ async def stream_derivative_orders(self, market_id: str, **kwargs):
749808
async def stream_derivative_trades(self, **kwargs):
750809
req = derivative_exchange_rpc_pb.StreamTradesRequest(
751810
market_id=kwargs.get("market_id"),
752-
market_ids=kwargs.get("market_ids"),
753-
subaccount_id=kwargs.get("subaccount_id"),
754-
subaccount_ids=kwargs.get("subaccount_ids"),
755811
execution_side=kwargs.get("execution_side"),
756812
direction=kwargs.get("direction"),
813+
subaccount_id=kwargs.get("subaccount_id"),
757814
skip=kwargs.get("skip"),
758815
limit=kwargs.get("limit"),
816+
start_time=kwargs.get("start_time"),
817+
end_time=kwargs.get("end_time"),
818+
market_ids=kwargs.get("market_ids"),
819+
subaccount_ids=kwargs.get("subaccount_ids"),
759820
execution_types=kwargs.get("execution_types"),
821+
trade_id=kwargs.get("trade_id"),
822+
account_address=kwargs.get("account_address"),
823+
cid=kwargs.get("cid"),
760824
)
761825
metadata = await self.network.exchange_metadata(
762826
metadata_query_provider=self._exchange_cookie_metadata_requestor

0 commit comments

Comments
 (0)