feat/update_gas_estimator_base_values #344
Conversation
…ator after chain upgrade v1.13
WalkthroughThe recent changes improve gas limit estimation in the Changes
Poem
TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (1)
tests/core/test_gas_limit_estimator.py (1)
Line range hint
26-26: Consider using a constant for expected message gas limit.The test case uses a hardcoded value
150,000. Consider replacing it with a relevant constant for consistency and maintainability.
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (3)
- pyinjective/core/gas_limit_estimator.py (3 hunks)
- tests/core/test_gas_limit_estimator.py (15 hunks)
- tests/core/test_message_based_transaction_fee_calculator.py (8 hunks)
Additional comments not posted (29)
tests/core/test_message_based_transaction_fee_calculator.py (7)
40-43: LGTM: Use of constants enhances maintainability.The use of
MessageBasedTransactionFeeCalculator.TRANSACTION_GAS_LIMITandPrivilegedExecuteContractGasLimitEstimator.BASIC_REFERENCE_GAS_LIMITimproves clarity and reduces hardcoding.
68-68: LGTM: Consistent use of transaction gas limit constant.The transition to using
MessageBasedTransactionFeeCalculator.TRANSACTION_GAS_LIMITsupports the goal of reducing hardcoded values.
90-90: LGTM: Use of transaction gas limit constant is appropriate.Replacing hardcoded values with
MessageBasedTransactionFeeCalculator.TRANSACTION_GAS_LIMITimproves maintainability.
112-112: LGTM: Consistent use of transaction gas limit constant.The change to use
MessageBasedTransactionFeeCalculator.TRANSACTION_GAS_LIMITsupports the goal of reducing hardcoded values.
142-142: LGTM: Use of transaction gas limit constant is appropriate.The transition to using
MessageBasedTransactionFeeCalculator.TRANSACTION_GAS_LIMITimproves maintainability.
173-175: LGTM: Use of multiple gas limit constants improves clarity.The use of
MessageBasedTransactionFeeCalculator.TRANSACTION_GAS_LIMIT,GenericExchangeGasLimitEstimator.BASIC_REFERENCE_GAS_LIMIT, andExecGasLimitEstimator.DEFAULT_GAS_LIMITenhances maintainability and accuracy.
211-214: LGTM: Consistent use of gas limit constants.The transition to using constants for gas limits enhances clarity and reduces hardcoding.
pyinjective/core/gas_limit_estimator.py (8)
15-15: LGTM: UpdatedSPOT_ORDER_CREATION_GAS_LIMITto 52,000.The change aligns with the intended update to reflect new gas costs.
16-16: LGTM: UpdatedDERIVATIVE_ORDER_CREATION_GAS_LIMITto 84,000.The change aligns with the intended update to reflect new gas costs.
18-18: LGTM: UpdatedDERIVATIVE_ORDER_CANCELATION_GAS_LIMITto 68,000.The change aligns with the intended update to reflect new gas costs.
20-20: LGTM: UpdatedSPOT_POST_ONLY_ORDER_MULTIPLIERto 0.62.The change aligns with the intended update to reflect new multiplier values.
21-21: LGTM: UpdatedDERIVATIVE_POST_ONLY_ORDER_MULTIPLIERto 0.35.The change aligns with the intended update to reflect new multiplier values.
25-25: LGTM: UpdatedGENERAL_MESSAGE_GAS_LIMITto 25,000.The change aligns with the intended update to reflect new gas limits.
186-186: LGTM: UpdatedMESSAGE_GAS_LIMITto 30,000.The change aligns with the intended update to reflect new gas limits.
249-249: LGTM: UpdatedDEFAULT_GAS_LIMITto 20,000.The change aligns with the intended update to reflect new gas limits.
tests/core/test_gas_limit_estimator.py (14)
59-60: LGTM: Consistent use of gas limit constants.The transition to using
SPOT_ORDER_CREATION_GAS_LIMITandBatchCreateSpotLimitOrdersGasLimitEstimator.GENERAL_MESSAGE_GAS_LIMITenhances clarity and reduces hardcoding.
87-88: LGTM: Consistent use of gas limit constants.The transition to using
SPOT_ORDER_CANCELATION_GAS_LIMITandBatchCancelSpotOrdersGasLimitEstimator.GENERAL_MESSAGE_GAS_LIMITenhances clarity and reduces hardcoding.
118-119: LGTM: Consistent use of gas limit constants.The transition to using
DERIVATIVE_ORDER_CREATION_GAS_LIMITandBatchCreateDerivativeLimitOrdersGasLimitEstimator.GENERAL_MESSAGE_GAS_LIMITenhances clarity and reduces hardcoding.
146-147: LGTM: Consistent use of gas limit constants.The transition to using
DERIVATIVE_ORDER_CANCELATION_GAS_LIMITandBatchCancelDerivativeOrdersGasLimitEstimator.GENERAL_MESSAGE_GAS_LIMITenhances clarity and reduces hardcoding.
181-182: LGTM: Consistent use of gas limit constants.The transition to using
SPOT_ORDER_CREATION_GAS_LIMITandBatchUpdateOrdersGasLimitEstimator.MESSAGE_GAS_LIMITenhances clarity and reduces hardcoding.
218-219: LGTM: Consistent use of gas limit constants.The transition to using
DERIVATIVE_ORDER_CREATION_GAS_LIMITandBatchUpdateOrdersGasLimitEstimator.MESSAGE_GAS_LIMITenhances clarity and reduces hardcoding.
275-276: LGTM: Consistent use of gas limit constants.The transition to using
DERIVATIVE_ORDER_CREATION_GAS_LIMITandBatchUpdateOrdersGasLimitEstimator.MESSAGE_GAS_LIMITenhances clarity and reduces hardcoding.
309-310: LGTM: Consistent use of gas limit constants.The transition to using
SPOT_ORDER_CANCELATION_GAS_LIMITandBatchUpdateOrdersGasLimitEstimator.MESSAGE_GAS_LIMITenhances clarity and reduces hardcoding.
343-344: LGTM: Consistent use of gas limit constants.The transition to using
DERIVATIVE_ORDER_CANCELATION_GAS_LIMITandBatchUpdateOrdersGasLimitEstimator.MESSAGE_GAS_LIMITenhances clarity and reduces hardcoding.
378-379: LGTM: Consistent use of gas limit constants.The transition to using
DERIVATIVE_ORDER_CANCELATION_GAS_LIMITandBatchUpdateOrdersGasLimitEstimator.MESSAGE_GAS_LIMITenhances clarity and reduces hardcoding.
398-399: LGTM: Consistent use of gas limit constants.The transition to using
BatchUpdateOrdersGasLimitEstimator.CANCEL_ALL_SPOT_MARKET_GAS_LIMITandBatchUpdateOrdersGasLimitEstimator.MESSAGE_GAS_LIMITenhances clarity and reduces hardcoding.
418-419: LGTM: Consistent use of gas limit constants.The transition to using
BatchUpdateOrdersGasLimitEstimator.CANCEL_ALL_DERIVATIVE_MARKET_GAS_LIMITandBatchUpdateOrdersGasLimitEstimator.MESSAGE_GAS_LIMITenhances clarity and reduces hardcoding.
438-439: LGTM: Consistent use of gas limit constants.The transition to using
BatchUpdateOrdersGasLimitEstimator.CANCEL_ALL_DERIVATIVE_MARKET_GAS_LIMITandBatchUpdateOrdersGasLimitEstimator.MESSAGE_GAS_LIMITenhances clarity and reduces hardcoding.
467-469: LGTM: Consistent use of gas limit constants.The transition to using
SPOT_ORDER_CREATION_GAS_LIMIT,BatchUpdateOrdersGasLimitEstimator.MESSAGE_GAS_LIMIT, andExecGasLimitEstimator.DEFAULT_GAS_LIMITenhances clarity and reduces hardcoding.
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (2)
- CHANGELOG.md (1 hunks)
- pyproject.toml (1 hunks)
Files skipped from review due to trivial changes (2)
- CHANGELOG.md
- pyproject.toml
Solves CHAIN-172
Summary by CodeRabbit
New Features
Bug Fixes
Documentation
Chores