Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[U26C] Pipeline reproduction (SPM deriv) #132

Closed
8 of 9 tasks
cmaumet opened this issue Dec 14, 2023 · 4 comments
Closed
8 of 9 tasks

[U26C] Pipeline reproduction (SPM deriv) #132

cmaumet opened this issue Dec 14, 2023 · 4 comments
Labels
✨ goal: improvement Improvement to an existing feature 🏁 status: ready for dev Ready for work

Comments

@cmaumet
Copy link
Contributor

cmaumet commented Dec 14, 2023

Softwares

SPM

Input data

derivatives (fMRIprep)

Additional context

Link to shared analysis code : https://github.com/gladomat/narps

List of tasks

Please tick the boxes below once the corresponding task is finished. 👍

  • 👌 A maintainer of the project approved the issue, by assigning a 🏁status: ready for dev label to it.
  • 🌳 Create a branch on your fork to start the reproduction.
  • 🌅 Create a file team_{team_id}.py inside the narps_open/pipelines/ directory. You can use a file inside narps_open/pipelines/templates as a template if needed.
  • 📥 Create a pull request as soon as you completed the previous task.
  • 🧠 Write the code for the pipeline, using Nipype and the file architecture described in docs/pipelines.md.
  • 📘 Make sure your code is documented enough.
  • 🐍 Make sure your code is explicit and conforms with PEP8.
  • 🔬 Create tests for your pipeline. You can use files in tests/pipelines/test_team_* as examples.
  • 🔬 Make sure your code passes all the tests you created (see docs/testing.md).
@cmaumet cmaumet added the 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work label Dec 14, 2023
@cmaumet
Copy link
Contributor Author

cmaumet commented Dec 14, 2023

@bclenet - checking the original code from the authors at https://github.com/gladomat/narps it looks like they are already using nipype 🎉 Can I leave this one to you then to refactor into narps_open?

@bclenet bclenet self-assigned this Jan 19, 2024
@bclenet bclenet mentioned this issue Jan 23, 2024
8 tasks
@bclenet bclenet added 🏁 status: ready for dev Ready for work and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Jan 26, 2024
@bclenet
Copy link
Collaborator

bclenet commented Feb 5, 2024

Correlation values :

Team Number of subjects Test status Correlation values
U26C 20 subjects failure [0.67, 0.61, 0.67, 0.61, -0.53, -0.49, 0.53, 0.49, 0.4]

These looks promising, but the sign issue for hypothese 5 and 6 must be solved.

@bclenet bclenet added the ✨ goal: improvement Improvement to an existing feature label Feb 5, 2024
@bclenet
Copy link
Collaborator

bclenet commented Feb 7, 2024

Issue with H5 and H6 resolved.

Team Number of subjects Test status Correlation values
U26C 20 subjects success [0.67, 0.61, 0.67, 0.61, 0.53, 0.49, 0.53, 0.49, 0.4]
U26C 40 subjects success [0.84, 0.79, 0.84, 0.79, 0.8, 0.71, 0.8, 0.71, 0.75]
U26C 60 subjects failure [0.9, 0.85, 0.9, 0.85, 0.93, 0.78, 0.93, 0.78, 0.86]

@bclenet
Copy link
Collaborator

bclenet commented Feb 12, 2024

Final correlation values

Team Number of subjects Test status Correlation values
U26C 20 subjects success [0.67, 0.61, 0.67, 0.61, 0.53, 0.49, 0.53, 0.49, 0.4]
U26C 40 subjects success [0.84, 0.79, 0.84, 0.79, 0.8, 0.71, 0.8, 0.71, 0.75]
U26C 60 subjects success [0.9, 0.85, 0.9, 0.85, 0.93, 0.78, 0.93, 0.78, 0.86]
U26C 80 subjects success [0.95, 0.96, 0.95, 0.96, 0.96, 0.91, 0.96, 0.91, 0.94]
U26C 108 subjects success [1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0, 1.0]

@bclenet bclenet closed this as completed Feb 12, 2024
@bclenet bclenet removed their assignment Feb 12, 2024
@cmaumet cmaumet changed the title [U26C] Pipeline reproduction [U26C] Pipeline reproduction (SPM deriv) Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ goal: improvement Improvement to an existing feature 🏁 status: ready for dev Ready for work
Projects
Development

No branches or pull requests

2 participants