From 08bc946edce014ce98dc937d137b1b3b3015d71a Mon Sep 17 00:00:00 2001
From: Bradley Lowekamp <blowekamp@mail.nih.gov>
Date: Mon, 25 Nov 2024 09:52:10 -0500
Subject: [PATCH] BUG: Address race condition with threaded copying input to
 output

Move copying input to output to before threaded methods, to ensure
the operation has been completed before modifications.
---
 .../itkObjectMorphologyImageFilter.hxx        | 21 ++++++++++---------
 1 file changed, 11 insertions(+), 10 deletions(-)

diff --git a/Modules/Filtering/BinaryMathematicalMorphology/include/itkObjectMorphologyImageFilter.hxx b/Modules/Filtering/BinaryMathematicalMorphology/include/itkObjectMorphologyImageFilter.hxx
index e5d3e1e37e8..67d0dee6ba0 100644
--- a/Modules/Filtering/BinaryMathematicalMorphology/include/itkObjectMorphologyImageFilter.hxx
+++ b/Modules/Filtering/BinaryMathematicalMorphology/include/itkObjectMorphologyImageFilter.hxx
@@ -100,17 +100,11 @@ ObjectMorphologyImageFilter<TInputImage, TOutputImage, TKernel>::BeforeThreadedG
   {
     this->GetOutput()->FillBuffer(0);
   }
-}
 
-template <typename TInputImage, typename TOutputImage, typename TKernel>
-void
-ObjectMorphologyImageFilter<TInputImage, TOutputImage, TKernel>::DynamicThreadedGenerateData(
-  const OutputImageRegionType & outputRegionForThread)
-{
-  ImageRegionConstIterator<TInputImage> iRegIter;
-  ImageRegionIterator<TOutputImage>     oRegIter;
-  iRegIter = ImageRegionConstIterator<InputImageType>(this->GetInput(), outputRegionForThread);
-  oRegIter = ImageRegionIterator<OutputImageType>(this->GetOutput(), outputRegionForThread);
+  RegionType requestedRegion = this->GetOutput()->GetRequestedRegion();
+
+  auto iRegIter = ImageRegionConstIterator<InputImageType>(this->GetInput(), requestedRegion);
+  auto oRegIter = ImageRegionIterator<OutputImageType>(this->GetOutput(), requestedRegion);
   /* Copy the input image to the output image - then only boundary pixels
    * need to be changed in the output image */
   while (!oRegIter.IsAtEnd())
@@ -122,7 +116,14 @@ ObjectMorphologyImageFilter<TInputImage, TOutputImage, TKernel>::DynamicThreaded
     ++oRegIter;
     ++iRegIter;
   }
+}
+
 
+template <typename TInputImage, typename TOutputImage, typename TKernel>
+void
+ObjectMorphologyImageFilter<TInputImage, TOutputImage, TKernel>::DynamicThreadedGenerateData(
+  const OutputImageRegionType & outputRegionForThread)
+{
   // Find the boundary "faces"
   NeighborhoodAlgorithm::ImageBoundaryFacesCalculator<InputImageType>                        fC;
   typename NeighborhoodAlgorithm::ImageBoundaryFacesCalculator<InputImageType>::FaceListType faceList =