Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation Error with libtiff's CMath::CMath dependency. #4987

Closed
blowekamp opened this issue Nov 25, 2024 · 6 comments
Closed

Compilation Error with libtiff's CMath::CMath dependency. #4987

blowekamp opened this issue Nov 25, 2024 · 6 comments
Labels
type:Bug Inconsistencies or issues which will cause an incorrect result under some or all circumstances

Comments

@blowekamp
Copy link
Member

Building SimpleITK against an installed ITK from the master branch has the following error:

 The link interface of target "itktiff" contains:

    CMath::CMath

  but the target was not found.  Possible reasons include:

    * There is a typo in the target name.
    * A find_package call is missing for an IMPORTED target.
    * An ALIAS target is missing.

https://github.com/SimpleITK/SimpleITK/actions/runs/11990814469/job/33428736685
https://open.cdash.org/viewBuildError.php?buildid=10045709

Description

Steps to Reproduce

Expected behavior

Actual behavior

Reproducibility

Versions

Environment

Additional Information

@blowekamp blowekamp added the type:Bug Inconsistencies or issues which will cause an incorrect result under some or all circumstances label Nov 25, 2024
@blowekamp
Copy link
Member Author

It look like libtiff defines a custom imported target:
https://github.com/InsightSoftwareConsortium/ITK/blob/master/Modules/ThirdParty/TIFF/src/itktiff/cmake/FindCMath.cmake

@bradking Would you agree the best way to address this for ITK is to update libtiff to use "CMath_INCLUDE_DIRS" and "CMath_LIBRARIES" over the imported target?

@bradking
Copy link
Member

@blowekamp yes, that's the simplest solution. I don't know why TIFF has a find module for a standard C library component.

@SimonRit
Copy link

Thanks, the fix did work for RTK, see here and here.

@dzenanz
Copy link
Member

dzenanz commented Nov 29, 2024

Should this be closed now?

@dzenanz
Copy link
Member

dzenanz commented Dec 12, 2024

@blowekamp close this?

@blowekamp
Copy link
Member Author

closed by #4989

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:Bug Inconsistencies or issues which will cause an incorrect result under some or all circumstances
Projects
None yet
Development

No branches or pull requests

4 participants