Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cancel-in-progress wrongly implemented #101

Open
SimonRit opened this issue Dec 10, 2024 · 2 comments
Open

cancel-in-progress wrongly implemented #101

SimonRit opened this issue Dec 10, 2024 · 2 comments

Comments

@SimonRit
Copy link
Collaborator

I am sorry but it seems that #98 and #99 have messed up the CI of remote modules (e.g. RTK). I think that the problem is that when combining .github/workflows/build-test-cxx.yml and .github/workflows/build-test-package-python.yml in a single file (as in https://github.com/RTKConsortium/RTK/blob/master/.github/workflows/build-test-package.yml), one of the two (the first one I guess) is cancelled. I don't see a solution for this, maybe we should just revert the two commits and implement cancel-in-progress) in the module files instead?
Sorry for the trouble...

@dzenanz
Copy link
Member

dzenanz commented Dec 10, 2024

We should act quickly, then. Do you want to propose another solution, or just revert the existing change?

@SimonRit
Copy link
Collaborator Author

I have tried a few things but failed. I think this is the same issue as actions/runner#3205. I'll prepare two PRs to revert, you can merge unless someone wants to pitch in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants