Skip to content

Commit f311ece

Browse files
author
Ali Abdelfattah
authored
Merge pull request #479 from Instabug/hotfix/android-sourcemap-version-name
🐛 Fix version name uploading on Android [INSD-3904]
2 parents b054350 + f5fce42 commit f311ece

File tree

3 files changed

+8
-2
lines changed

3 files changed

+8
-2
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## v9.1.1 (2020-04-06)
2+
3+
* Fixes an issue with the version name while uploading the sourcemap on Android.
4+
15
## v9.1.0 (2020-03-19)
26

37
* Bump Native SDKs to v9.1

android/upload_sourcemap.sh

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ else
2525
exit 0
2626
fi
2727
fi
28-
if [ ! "${INSTABUG_APP_VERSION_CODE}" ] || [ -z "${INSTABUG_APP_VERSION_CODE}" ]; then
28+
if [ ! "${INSTABUG_APP_VERSION_NAME}" ] || [ -z "${INSTABUG_APP_VERSION_NAME}" ]; then
2929
INSTABUG_APP_VERSION_NAME=$(grep "versionName" android/app/build.gradle | awk '{print $2}' | tr -d \''"\')
3030
if [ ! "${INSTABUG_APP_VERSION_NAME}" ] || [ -z "${INSTABUG_APP_VERSION_NAME}" ]; then
3131
echo "versionName could not be found, please upload the sourcemap files manually"
@@ -34,6 +34,8 @@ else
3434
fi
3535
VERSION='{"code":"'"$INSTABUG_APP_VERSION_CODE"'","name":"'"$INSTABUG_APP_VERSION_NAME"'"}'
3636
echo "Instabug: Token found" "\""${INSTABUG_APP_TOKEN}"\""
37+
echo "Instabug: Version Code found" "\""${INSTABUG_APP_VERSION_CODE}"\""
38+
echo "Instabug: Version Name found" "\""${INSTABUG_APP_VERSION_NAME}"\""
3739
echo "Instabug: Generating sourcemap files..."
3840
IS_HERMES=$(grep "enableHermes:" ./android/app/build.gradle)
3941
if [[ $IS_HERMES == *"true"* ]]; then

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "instabug-reactnative",
3-
"version": "9.1.0",
3+
"version": "9.1.1",
44
"description": "React Native plugin for integrating the Instabug SDK",
55
"main": "index.js",
66
"types": "index.d.ts",

0 commit comments

Comments
 (0)