Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log test case exceptions instead of just throwing #64

Open
2 of 3 tasks
PandaMagnus opened this issue Jan 28, 2020 · 2 comments
Open
2 of 3 tasks

Log test case exceptions instead of just throwing #64

PandaMagnus opened this issue Jan 28, 2020 · 2 comments
Assignees

Comments

@PandaMagnus
Copy link
Collaborator

PandaMagnus commented Jan 28, 2020

Currently we log that a test failed, but don't log the exception. This is problematic if you're running the tests in an environment where the exception isn't captured and logged (E.G. AzureDevops will automatically log exceptions to a build or release log.) Might be worth it to log the exception before throwing.

Logging to-do's:

  • Log test case exceptions instead of just throwing
  • Make sure logging from ExecuteTestCase is at a uniform level (prefer Debug as much as possible)
  • Update logging around serializing JSON
@PandaMagnus PandaMagnus self-assigned this Feb 12, 2020
@PandaMagnus
Copy link
Collaborator Author

Also need to update how test block inputs and outputs are logged. Noticed at a client that one is as Info one is as Debug. Probably want most or all "automatic" logging to go to Debug outside of errors and maybe the test case name.

@PandaMagnus
Copy link
Collaborator Author

Also need better messaging around when an item can't be serialized to JSON. E.G. if we don't have a [JsonIgnore] property on a property that mucks around with Selenium before the site is launched, it will fail with a selenium exception. Need to gracefully log instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant