-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compatibility with EWWW Image Optimizer #79
Comments
Just went to try this out again, but doesn't seem anything has changed, am I missing something, or is this just a "won't fix"? |
@nosilver4u Sorry man, I've had my hands in a lot of fires this last month. This was closed out on accident. If you can drop me a line, I'd love to get better support for EWWW integrated. You can reach me at [email protected] |
no worries, I'll shoot you an email shortly |
Has this issue been resolved? Wanting to use these plugins together but not sure if they're fully compatible. Thanks. |
Hi,
I'm the dev for EWWW IO, and some of our users had asked for compatibility with your plugin.
I was looking through your plugin today, and it seems to work fine for new uploads, but optimizing an image after it's already on S3 doesn't seem to trigger any updates to S3.
Looking through the storage class, it seems this is because Media Cloud basically short-circuits itself on the wp_update_attachment_metadata filter if an image optimizer plugin exists, and then runs on our ewww_image_optimizer_post_optimization action.
However, when EWWW IO is optimizing an existing image, that action fires before wp_update_attachment_metadata, and so nothing happens with S3.
If there's anything I can change in EWWW IO to make this work with Media Cloud, do let me know. Latest EWWW IO code is at http://github.com/nosilver4u/ewww-image-optimizer/
The text was updated successfully, but these errors were encountered: