-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Support for stop words #350
Comments
|
Added in #352 |
Awesome, thanks for the fast update! Would it be possible to pass in a string / sequence of strings and have those be converted to the tokens under the hood (similar to the OpenAI API interface?) Or possibly provide documentation on how stop_words should be created from a list of stop sequence strings. |
I am afraid using string or sequence might not be a good idea for two reasons:
|
@AllentDan Can you make a document, presenting chat templates and their usage? |
Yeah, I would add documents later but in other pull requests. |
That's understandable. So how does every other library/API offer this? vLLM, OpenAI, etc. |
My mistake. We'll carefully consider that |
Merged to main |
Checklist
Describe the bug
The ability for the user to specify
stop_words
does not seem to be exposed. I see that the TurboMind instances has a stop_words attribute but it doesn't seem to be customizable.Reproduction
.
Error traceback
No response
The text was updated successfully, but these errors were encountered: