Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Declare optional packages to reduce package size #459

Closed
gabrielfu opened this issue Sep 23, 2023 · 5 comments
Closed

[Feature] Declare optional packages to reduce package size #459

gabrielfu opened this issue Sep 23, 2023 · 5 comments
Assignees

Comments

@gabrielfu
Copy link

gabrielfu commented Sep 23, 2023

Motivation

Currently running pip install lmdeploy installs everything like torch, triton, gradio, etc., which makes it very slow and occupies a lot of storage (especially if I'm building a docker image on top of it).

In reality, I often only need the torch functionality and don't need triton.

It will be nice if I can choose what functionality I want to install:

pip install lmdeploy[torch]
pip install lmdeploy[triton]
pip install lmdeploy[gradio]

Related resources

No response

Additional context

No response

@lvhan028
Copy link
Collaborator

That's a great idea. @RunningLeon could you help support this feature?

@RunningLeon
Copy link
Collaborator

@gabrielfu hi, thanks for your suggestion. We'll consider your suggestion and try to come up with a good solution.

@lvhan028
Copy link
Collaborator

@gabrielfu could you help check if PR #580 meets your request

@gabrielfu
Copy link
Author

@gabrielfu could you help check if PR #580 meets your request

@lvhan028 Looks great to me. Will be even better if there's more documentations on which optional package provides which functionalities. Thanks a lot for the update!

@RunningLeon
Copy link
Collaborator

@gabrielfu hi, the installation infomation is updated in README.md. Any comment would be appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants