-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scratchsig doesn't work with echo #16
Comments
My idea based on Kenny2github's idea: https://discord.com/channels/328938947717890058/764646854343655464/1185315307112374382 OK, thinking about this some more I have some new ideas. PFPs can work via user ID, and they can be put in "in-plae" at time of editing, this saves recursive calls. For legacy tag, archive pages can be edited. This means that history diffs will break, but maybe there can be a tag there that doesn't use lookups or something So something like:
And a magic tag like Then, the default signature is:
|
My opinion is that you should consider the original |
Hmmm.. OK, but this confuses me, because changing how signatures work and moving avatars to a different tag was your idea in the first place. Did I misunderstand you or did you change your mind? Either way please let me know, thank you. |
My idea was to add a different tag for the new kind of signature and use that going forward. In all cases my intent was for |
OK. That's what I meant as well. The external calls could probably go away but other than that there's no need to change it. These are proposals for new tags and usage from now on--old edits wouldn't need to be changed since only new ones would generate notifications. Which of them does everyone think is best? |
Making a talk page post and signing it with scratchsig won't trigger an Echo notification.
Echo works by "expanding" the wikitext including templates and such into the actual formatting that would be rendered into HTML, and scanning that for an appropriate link. A link to your userpage, talk page, or contributions page is required for a notification to be sent.
Unfortunately, because scratchsig isn't a template or module, and is an actual tag, that's as far as the "expanding" process would go--because that tag spits out HTML, even if it does so via wikitext. This means that in its current state, scratchsig won't work with Echo.
@jacob-g has created a short-term mitigation for this issue by hacking the Echo core to look for the scratchsig tags, but this isn't a good long-term solution.
Other ideas suggested include:
** This was suggested by @Kenny2github though I expanded on this in further detail
** The main argument for this would be that only the English wiki has ever used it, so removing it would make it more like the other wikis
This issue is a good place to track the long-term Echo issue
The text was updated successfully, but these errors were encountered: