Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation Links Not Landing on Target Section #885

Closed
dpgiakatos opened this issue Jan 14, 2025 Discussed in #884 · 10 comments
Closed

Navigation Links Not Landing on Target Section #885

dpgiakatos opened this issue Jan 14, 2025 Discussed in #884 · 10 comments
Assignees
Labels

Comments

@dpgiakatos
Copy link
Member

Discussed in #884

Originally posted by Ronit0104123 January 10, 2025
I noticed an issue on the IHR website where links in the Home Page(e.g., "Network Delay"), intended to navigate to a specific section of documentation instead land at the top of the target page, that is the documentation page.
Because of this users need to scroll manually to find the relevant content. I believe this can be resolved by ensuring the correct ID is targeted in the links, for the link to navigate to that particular section
Screenshot 2025-01-10 at 13 28 11
Screenshot 2025-01-10 at 13 28 28

Would it be possible to open an issue for this? I'd be happy to contribute to fixing it if needed!
Looking forward to your response.

@dpgiakatos
Copy link
Member Author

This is an easy issue to resolve. The problem occurs because the links on the landing page contain an underscore (_) instead of a dash (-). For example:
en/documentation#AS_dependency should be en/documentation#AS-dependency.

The solution is to replace the underscore with a dash in the links on the homepage.

Please, before opening a PR, make sure you are assigned to this issue first. When you open the PR, kindly ping me for a code review.

Thanks!

@TejasNangru
Copy link

Sir, I will like to work on this issue,
Kindly assign me this issue.

@dpgiakatos
Copy link
Member Author

Hello, since you are already working on an issue for another IHR project (InternetHealthReport/raclette#31), I would like to avoid assigning multiple issues to the same person. Thank you for your understanding.

@abansal15
Copy link
Contributor

Hello @dpgiakatos could you please assign this issue to me i would like to solve this issue

@Ronit0104123
Copy link
Contributor

Hello, I have already worked on this solution. Can you please assign me this issue so I can work on it?

@TejasNangru
Copy link

Hello, since you are already working on an issue for another IHR project (InternetHealthReport/raclette#31), I would like to avoid assigning multiple issues to the same person. Thank you for your understanding.

Ok sir!

@dpgiakatos
Copy link
Member Author

Hello, I have already worked on this solution. Can you please assign me this issue so I can work on it?

Hello @Ronit0104123, since you are a first-time contributor to the IHR organization and are not currently working on another issue, I will assign this issue to you. However, in the future, please refrain from working on an issue unless you are assigned to it (our contribution guidelines). Thank you!

@Chayan8837
Copy link

i am also working on it

Chayan8837 added a commit to Chayan8837/ihr-website that referenced this issue Jan 14, 2025
@Chayan8837 Chayan8837 mentioned this issue Jan 14, 2025
6 tasks
@dpgiakatos
Copy link
Member Author

Dear community,

We appreciate your eagerness to contribute to our organization; however, we must adhere to our contribution guidelines.

Snapshot from our contribution guidelines:

  1. PRs that are not assigned to an issue will be closed automatically.
  2. Please do not implement code if you are not assigned to the issue.

That said, @Ronit0104123 is already assigned to this issue, so the PR #888 will be closed automatically.

Thank you for your understanding.

@Ronit0104123
Copy link
Contributor

Fixed this issue in #889

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants