-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Governance metadata is not validated #906
Governance metadata is not validated #906
Comments
In case cli plans to support this, we have implemented metadata parsers following the above cips https://github.com/IntersectMBO/cardano-db-sync/blob/master/cardano-db-sync/src/Cardano/DbSync/OffChain/Vote/Types.hs |
cardano-signer is doing checks if a metadata file is valid, also checks about the signatures. |
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 120 days. |
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 120 days. |
Description
There is no metadata validation for the governance metadata. Right now is possible to submit a governance action with wrong metadata/missing required fields and the only time we can see an error is when dbsync try to catch the data.
Steps to Reproduce
e.g.
cardano-cli conway governance drep metadata-hash --drep-metadata-file drep_metadata.json
drep_metadata.json -> missing givenName that is marked as Compulsory in cip-0119
Additional Context
CIPs related to governance metadata:
https://github.com/cardano-foundation/CIPs/tree/master/CIP-0100
https://github.com/cardano-foundation/CIPs/tree/master/CIP-0108
https://github.com/cardano-foundation/CIPs/tree/master/CIP-0119
The text was updated successfully, but these errors were encountered: