Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Showing delegated DRep Id after delegation is slow #1089

Closed
spannercode opened this issue May 24, 2024 · 10 comments
Closed

Showing delegated DRep Id after delegation is slow #1089

spannercode opened this issue May 24, 2024 · 10 comments
Assignees
Labels
🐛 Bug Something isn't working

Comments

@spannercode
Copy link
Contributor

spannercode commented May 24, 2024

User story:
2A. Should show delegated DRep Id (on Dashboard, and DRep Directory) after delegation

Description:
After delegation on Dashboard, DRep Directory, the DRep Id is reflected after a lag. This is causing test to timeout.

Related other stories which fail because of the slow UI response:
2F. Should change delegated DRep

@spannercode spannercode added the 🐛 Bug Something isn't working label May 24, 2024
@pmbinapps
Copy link
Contributor

Need to decide what timeout length is acceptable.
Here recoding of a Delegation which lasted apx 25 sek.

@MSzalowski
Copy link
Contributor

Transaction might be on In Progress even up to 3 minutes.

@Ryun1 could you please verify if that is true?

@Ryun1
Copy link
Member

Ryun1 commented Jun 7, 2024

Transaction might be on In Progress even up to 3 minutes.

@Ryun1 could you please verify if that is true?

Yup

@spannercode
Copy link
Contributor Author

The reason for the timeout on test was the lag to show the DRep Id even after the transaction is completed. The test waits for the transaction to be completed before it expects to see the updates on the page.
Screenshot 2024-06-10 at 06 32 57

@bosko-m
Copy link
Contributor

bosko-m commented Jun 10, 2024

@spannercode Should anything be fixed then in the code? Perhaps on the test itself?

@NabinKawan
Copy link
Contributor

NabinKawan commented Jun 21, 2024

It is due to a null reference error in the function getData.
Error:

null (reading 'dRepHash')
    at lKe (index-98ec2c1b.js:398:27075)
    at async u0 (index-98ec2c1b.js:398:28410)
lKe @ index-98ec2c1b.js:398
o4507027845021696.ingest.us.sentry.io/api/4507101527277568/envelope/?sentry_key=69300ede4a476619986b4f6c4f3193d4&sentry_version=7&sentry_client=sentry.javascript.react%2F7.116.0:1 

This error prevents the transaction status from being updated.

Source code from where the error is generated:
image

sentry link

@MSzalowski Could you please have a look on this?

@NabinKawan
Copy link
Contributor

@spannercode Should anything be fixed then in the code? Perhaps on the test itself?

@bosko-m It should be fixed in the code.

@MSzalowski MSzalowski moved this to To do in Govtool all Jun 21, 2024
@spannercode
Copy link
Contributor Author

Linking the PR to address this issue:

CC: @MSzalowski

@bosko-m
Copy link
Contributor

bosko-m commented Jul 23, 2024

Will be handled after DBSync 5.1.0 issue is resolved.

@bosko-m
Copy link
Contributor

bosko-m commented Aug 8, 2024

@spannercode @MSzalowski Is this resolved?

@bosko-m bosko-m moved this from To do to In QA in Govtool all Aug 8, 2024
@bosko-m bosko-m closed this as completed Oct 21, 2024
@github-project-automation github-project-automation bot moved this from In QA to Done in Govtool all Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

6 participants