Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Deep link (Shared Link) of Governance Action does not work #1801

Closed
spannercode opened this issue Aug 23, 2024 · 2 comments · Fixed by #1818
Closed

🐛 Deep link (Shared Link) of Governance Action does not work #1801

spannercode opened this issue Aug 23, 2024 · 2 comments · Fixed by #1818
Assignees
Labels
🐛 Bug Something isn't working 🗳️ Voting Pillar

Comments

@spannercode
Copy link
Contributor

Area

Voting Pillar

Domain

sanchogov.tools

Which wallet were you using?

Not relevant

Context

Loading a governance action page by URL is leads to a blank page. However, the page loads correctly when going through the GovTool governance page.

This breaks any other third party tools linking the GovTool governance actions.

Steps to reproduce

  1. Open in incognito mode the following URL:
    https://sanchogov.tools/governance_actions/3f52a04530e867db15a89ecde829a33bb35af939e5b043002b9fdc1ee4dee954#0

  2. The page shown is a blank screen.

  3. Check the console log, it shows the following stacktrace

index-b0fff2a5.js:90 TypeError: Cannot read properties of undefined (reading 'proposal')
    at P6i (index-b0fff2a5.js:455:135181)
    at fu0 (index-b0fff2a5.js:38:17974)
    at dX2 (index-b0fff2a5.js:40:44769)
    at lX2 (index-b0fff2a5.js:40:40396)
    at MG4 (index-b0fff2a5.js:40:40319)
    at Z00 (index-b0fff2a5.js:40:40167)
    at Fc0 (index-b0fff2a5.js:40:36434)
    at sX2 (index-b0fff2a5.js:40:35371)
    at E2 (index-b0fff2a5.js:25:1693)
    at MessagePort.ie (index-b0fff2a5.js:25:2092)
  1. Visiting the URL from the govenance_actions page works
    a) visit https://sanchogov.tools/governance_actions
    b) Select the No confidence gov action with given ID. At the moment of writing on sanchonet, there is only one such gov action shown.
    c) The page shows correctly.

Actual behavior

The individual governance action page does not load by using the URL. Here is the stacktrace:

index-b0fff2a5.js:90 TypeError: Cannot read properties of undefined (reading 'proposal')
    at P6i (index-b0fff2a5.js:455:135181)
    at fu0 (index-b0fff2a5.js:38:17974)
    at dX2 (index-b0fff2a5.js:40:44769)
    at lX2 (index-b0fff2a5.js:40:40396)
    at MG4 (index-b0fff2a5.js:40:40319)
    at Z00 (index-b0fff2a5.js:40:40167)
    at Fc0 (index-b0fff2a5.js:40:36434)
    at sX2 (index-b0fff2a5.js:40:35371)
    at E2 (index-b0fff2a5.js:25:1693)
    at MessagePort.ie (index-b0fff2a5.js:25:2092)

Expected behavior

  • The page loads correctly and shows the governance action details.
  • No errors logged on the console.
@spannercode spannercode added the 🐛 Bug Something isn't working label Aug 23, 2024
@spannercode spannercode changed the title 🐛 🐛 URL of individual Governance Action does not load Aug 23, 2024
@spannercode spannercode changed the title 🐛 URL of individual Governance Action does not load 🐛 Deep link (Shared Link) of Governance Action does not work Aug 23, 2024
Copy link

sentry-io bot commented Aug 23, 2024

Sentry Issue: GOVTOOL-FRONTEND-53

@MSzalowski MSzalowski self-assigned this Aug 23, 2024
@MSzalowski MSzalowski moved this to In progress in Govtool all Aug 23, 2024
@MSzalowski MSzalowski assigned jdyczka and unassigned MSzalowski Aug 23, 2024
@MSzalowski
Copy link
Contributor

@jdyczka I've reassigned it to you as I can see that you've already fixed that partially within 96e6674

@jdyczka jdyczka linked a pull request Aug 26, 2024 that will close this issue
5 tasks
jdyczka added a commit that referenced this issue Aug 26, 2024
…link-of-governance-action-does-not-work

[#1801] refactor passing props to GA details, fix ts problems
@github-project-automation github-project-automation bot moved this from In progress to Done in Govtool all Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working 🗳️ Voting Pillar
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants