Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propose New Constitution or Guardrails Script Governance Action for an offchain discussion and submit it as a governance action #2258

Closed
bosko-m opened this issue Oct 28, 2024 · 7 comments · Fixed by #2912
Assignees

Comments

@bosko-m
Copy link
Contributor

bosko-m commented Oct 28, 2024

  • Enable New Constitution or Guardrails Script GA type to be discussed offchain through the proposal discussion forum section
    • Add option Updates to the Constitution to the dropdown when proposing new GA
    • Use Treasury action as a reference
      • Instead of two fields for rewards make the following ones:
        • New constitution URL
        • Checkbox toggle with the following copy: Do you want to provide new guardrails script data? Upon clicking it should show/hide the following two fields:
          • Guardrails script URL
          • Guardrails script hash
      • There should be a validation on the New constitution URL as it needs to check whether its able to fetch content and whether its a text file
      • New constitution URL should support ipfs links as well
      • Keep title, abstract, motivation and rationale
      • Keep optional section for providing additional linkes
    • Constitution type should also be adequately displayed on the page listing all proposals
      • It should have its own section
      • It should also be available in the filter dropdown

Notes:

  • We should also change:
    • Treasury to Treasury requests
    • Info to Info Action
  • Submit as Governance Action button should be disabled for this specific type, Update to the Constitution
    • Once done it should be deployed to Preview to gather community feedback
    • The button can then be enabled along with the solution to submit tx on chain which is the part voting pillar team should be responsible for
@bosko-m bosko-m moved this to Backlog in Govtool all Nov 3, 2024
@bosko-m bosko-m moved this from Backlog to To do in Govtool all Nov 6, 2024
@bosko-m bosko-m moved this from To do to Backlog in Govtool all Nov 6, 2024
@bosko-m bosko-m changed the title Submit New Constitution and/or Guardrails Script Governance Action Propose New Constitution and/or Guardrails Script Governance Action for an offchain discussion - Proposal Discussion Forum Feb 3, 2025
@bosko-m bosko-m changed the title Propose New Constitution and/or Guardrails Script Governance Action for an offchain discussion - Proposal Discussion Forum Propose New Constitution or Guardrails Script Governance Action for an offchain discussion - Proposal Discussion Forum Feb 3, 2025
@bosko-m
Copy link
Contributor Author

bosko-m commented Feb 3, 2025

Description changed
@Ryun1 @nebojsact @l-br1

@l-br1
Copy link

l-br1 commented Feb 3, 2025

@bosko-m please double check the name of this option in the dropdown as it should match the GA 'Update to the constitution'

@l-br1
Copy link

l-br1 commented Feb 3, 2025

separate idea > for discussion of this GA we could link to https://constitution.gov.tools/en/interim-constitution

@bosko-m
Copy link
Contributor Author

bosko-m commented Feb 3, 2025

@l-br1

please double check the name of this option in the dropdown as it should match the GA 'Update to the constitution'

If we are to respect full names according to the CIP-1694 it should be New Constitution or Guardrails Script
Its also displayed as a label on a listed proposal:

Image

For example, Treasury is listed in the dropdown when you are choosing type and also as a label, while by CIP-1694 its full name is Treasury Withdrawals

Anyway, copy is really easy to be changed. 🙌

@l-br1
Copy link

l-br1 commented Feb 3, 2025

Yes, the name on 1694 is not always self-explanatory. If you check on the voting page filter you have a more user-friendly name, for now we should align to that

@l-br1
Copy link

l-br1 commented Feb 3, 2025

p.s. for treasury it would be better 'Treasury requests' or 'Treasury withdrawal requests'

@nebojsact nebojsact moved this from To do to In progress in Govtool all Feb 4, 2025
@bosko-m bosko-m changed the title Propose New Constitution or Guardrails Script Governance Action for an offchain discussion - Proposal Discussion Forum Propose New Constitution or Guardrails Script Governance Action for an offchain discussion and submit it as a governance action Feb 4, 2025
@bosko-m
Copy link
Contributor Author

bosko-m commented Feb 4, 2025

@nebojsact @l-br1 @m-i-k-e Adjusted description so it covers:

  • Supporting Update to the Constitution type for an offchain discussion only
  • Supporting Update to the Constitution type for submission to the chain for voting

Advanced solution with comparison is to be discussed and aligned in #2897 and should also include community feedback on the above.

@MSzalowski Once @nebojsact is done with the offchain part only and is deployed to preview we can integrate tx submission too.

CC @Ryun1

@nebojsact nebojsact moved this from In progress to In QA in Govtool all Feb 7, 2025
MSzalowski added a commit that referenced this issue Feb 11, 2025
…titution-or-guardrails-script-governance-action-for-an-offchain-discussion-and-submit-it-as-a-governance-action

feat(#2258): add support for submitting all governance action types
@github-project-automation github-project-automation bot moved this from In QA to Done in Govtool all Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants