Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Governance Action can be submitted multiple times consecutively without leaving the page #2264

Closed
bosko-m opened this issue Oct 28, 2024 · 4 comments
Assignees
Labels
🐛 Bug Something isn't working 📜 Proposal Pillar

Comments

@bosko-m
Copy link
Contributor

bosko-m commented Oct 28, 2024

Area

Proposal Pillar

Domain

preview.gov.tools

Which wallet were you using?

Lace

Context

Was exploring end 2 end user experience of a proposal evolving into the governance action.

Reference loom video - https://www.loom.com/share/b57d9f1ad28345e0b16415ca05549afa?sid=61f53e95-b96e-4cd3-bf7a-86d399d9dabd

Steps to reproduce

  1. Go to the specific proposal and submit it as governance action
  2. Fill in the steps all the way to the last screen where you could submit it
  3. Click submit
  4. On the success message modal click x to close it
  5. Click submit again

Actual behavior

  1. You are able to submit it

Expected behavior

  1. You shouldnt be able to submit it as upon success message you should be taken out of that screen to the list of governance actions or list of proposals where you can see your proposal you just submitted as governance action.
@kneerose
Copy link
Contributor

Screenshot from 2024-10-29 11-33-01

Displaying this popup would be a better option when the user tries to re-submit a proposal, until the transaction is completed

@m-i-k-e
Copy link

m-i-k-e commented Oct 29, 2024

@MSzalowski That will not fix the bug, as the user can dismiss this and re-submit. In UX you cannot depend on users to read instructions and follow them. The interface itself needs to be foolproof.

How do multiple GAs work? Do copies go on chain, or is there a different bug?

@bosko-m bosko-m moved this from Backlog to To do in Govtool all Nov 3, 2024
@nebojsact
Copy link

@bosko-m we need to clarify this bug, do we need to block user to submit one action based on one proposal? Or just redirect on some other page (Which one?), or just block pressing button again?

@nebojsact nebojsact assigned nebojsact and unassigned nebojsajsimic Nov 28, 2024
@bosko-m
Copy link
Contributor Author

bosko-m commented Nov 29, 2024

@nebojsact Disabling button seems like the right and simple thing to be done in that case.
Which means blocked until.you get the output of the submitted transaction, which can be successful or failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working 📜 Proposal Pillar
Projects
Archived in project
Development

No branches or pull requests

5 participants