Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 ADA quantities format incorrect on Governance Actions #2305

Closed
m-i-k-e opened this issue Nov 1, 2024 · 4 comments · Fixed by #2345
Closed

🐛 ADA quantities format incorrect on Governance Actions #2305

m-i-k-e opened this issue Nov 1, 2024 · 4 comments · Fixed by #2345
Assignees
Labels
🐛 Bug Something isn't working Other area

Comments

@m-i-k-e
Copy link

m-i-k-e commented Nov 1, 2024

Area

Other

Domain

preview.gov.tools

Which wallet were you using?

Latest Lace

Context

I am looking at a vote on governance. The numbers are very long after the decimal point. Also, there is no comma separator.

image

Steps to reproduce

Go to GA that has vote on it
Look at numbers

Actual behavior

Numbers display with six decimal places and no comma separators

Expected behavior

Numbers don't have any decimal part (they are rounded to the nearest ADA), and the ADA values are comma seperated.

@m-i-k-e
Copy link
Author

m-i-k-e commented Nov 1, 2024

Also, the numbers shouldn't be in bold. Please see this page in Figma: https://www.figma.com/design/mJTBiUofLfb74Xc3W2U59o/Voltaire---GOV-TOOL?m=auto&node-id=14736-93156&t=xaC11CQKDDby1Wbv-1

@HeptaSean
Copy link

Don't know if it's too late, but I would ask to please do not use a comma as thousands separator, but a space or thin space. Comma is very irritating internationally, especially where comma is used as decimal separator.

Although I would leave in the Lovelace exact values (why hide information?), but right-align and mono-space the whole thing, so that it can be easily grasped.

@bosko-m
Copy link
Contributor

bosko-m commented Nov 7, 2024

Never too late @HeptaSean 😁

@bosko-m
Copy link
Contributor

bosko-m commented Nov 14, 2024

@MSzalowski Verified on Preview, however, raised another issue to now show thousands if its zero - #2372. Was observed on SPO part.
So 0,000 should become just 0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working Other area
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants