Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Unwanted truncation for governance action links #2391

Closed
Ryun1 opened this issue Nov 19, 2024 · 4 comments · Fixed by #2397
Closed

🐛 Unwanted truncation for governance action links #2391

Ryun1 opened this issue Nov 19, 2024 · 4 comments · Fixed by #2397
Assignees
Labels
🐛 Bug Something isn't working 🗳️ Voting Pillar

Comments

@Ryun1
Copy link
Member

Ryun1 commented Nov 19, 2024

Area

Voting Pillar

Domain

sanchogov.tools

Which wallet were you using?

No response

Context

Reference links on proposals are truncated and broken in some cases
see ab633bb08e0e9fe33eef865b7acc079c8b2f360fb851a97230d135bd4fd8fc07#0

(see full metadata doc)

Steps to reproduce

see ab633bb08e0e9fe33eef865b7acc079c8b2f360fb851a97230d135bd4fd8fc07#0

Actual behavior

The second reference link is completely truncated off of the screen
The reference URIs are also not rendered on the line below

image

Expected behavior

All reference links are shown correctly
Allowing the both the label and URI to be seen

@MSzalowski
Copy link
Contributor

@m-i-k-e Wouldn't it be better to display label and url below label instead of both in one row?

@Crypto2099
Copy link

I don't see any functional benefit to treating the Supporting Links section as a 2-wide grid anyway. Most URIs will always be long enough to cause undesirable truncation.

I would strongly advocate simply making this a vertically linear "list" of items when there is one or more reference links to display.

@bosko-m
Copy link
Contributor

bosko-m commented Nov 19, 2024

I agree with @MSzalowski and @Crypto2099
You can proceed @MSzalowski

@MSzalowski MSzalowski moved this from To do to In progress in Govtool all Nov 20, 2024
@MSzalowski MSzalowski linked a pull request Nov 20, 2024 that will close this issue
5 tasks
@MSzalowski MSzalowski moved this from In progress to In review in Govtool all Nov 20, 2024
@m-i-k-e
Copy link

m-i-k-e commented Nov 20, 2024

We have a new design for this, but it's not been implemented. It does use a 1 x 2 table, but the links are not truncated. In any case, we don't want truncation.

MSzalowski added a commit that referenced this issue Nov 20, 2024
…tion-for-governance-action-links

feat(#2391): display supporing links in columns
@github-project-automation github-project-automation bot moved this from In review to Done in Govtool all Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working 🗳️ Voting Pillar
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants