-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Unwanted truncation for governance action links #2391
Comments
@m-i-k-e Wouldn't it be better to display label and url below label instead of both in one row? |
I don't see any functional benefit to treating the Supporting Links section as a 2-wide grid anyway. Most URIs will always be long enough to cause undesirable truncation. I would strongly advocate simply making this a vertically linear "list" of items when there is one or more reference links to display. |
I agree with @MSzalowski and @Crypto2099 |
We have a new design for this, but it's not been implemented. It does use a 1 x 2 table, but the links are not truncated. In any case, we don't want truncation. |
…tion-for-governance-action-links feat(#2391): display supporing links in columns
Area
Voting Pillar
Domain
sanchogov.tools
Which wallet were you using?
No response
Context
Reference links on proposals are truncated and broken in some cases
see ab633bb08e0e9fe33eef865b7acc079c8b2f360fb851a97230d135bd4fd8fc07#0
(see full metadata doc)
Steps to reproduce
see ab633bb08e0e9fe33eef865b7acc079c8b2f360fb851a97230d135bd4fd8fc07#0
Actual behavior
The second reference link is completely truncated off of the screen
The reference URIs are also not rendered on the line below
Expected behavior
All reference links are shown correctly
Allowing the both the label and URI to be seen
The text was updated successfully, but these errors were encountered: