-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 IPFS URL Format Not Fully Supported in Proposal Submission Metadata Anchor URL #2495
Comments
After detailed analyzing, this request is for @MSzalowski, in pdf is only form for submission, function and error checking is pulled from govtools (validateMetadata) |
Just tested it, and this is the result: https://www.loom.com/share/63db04e23475439ebe8bc96cc20a699e?sid=4bbf8e90-5235-4ae0-a3de-aea028661db1 GovTool does not find the URL, but the URL does exist and is browsable. |
On DRep registration: My metadata CID: Gateway used: https://ipfs.io |
@nebojsact That issue is on the PDF level. As you said, the wrapper provided metadata validation but on the second screen, there is not metadata validation as that error is displayed on the form level. I tested it using IPFS is supported by both GovTool wrapper and GovTool metadata validation service as DRep registration using IPFS links works (DRep registration is on the Wrapper level so far, and it validates the metadata using the validation service). Screenshot from postman using the ipfs link as a metadata source: |
Area
Proposal Pillar
Domain
dev-sanchogov.tools
Which wallet were you using?
No response
Context
I encountered an issue while trying to add an IPFS URL in the metadata anchor URL during proposal submission. The system does not support IPFS URLs in the
ipfs://<CID>
format, although it does support thehttps://ipfs.io/ipfs/<CID>
format.Both
https://ipfs.io/ipfs/<CID>
andipfs://<CID>
formats are supported.While the
https://ipfs.io/ipfs/<CID>
format is supported, theipfs://<CID>
format is not.Steps to reproduce
ipfs://<CID>
formatActual behavior
The proposal submission does not support the
ipfs://<CID>
format in the metadata anchor URL field, even though thehttps://ipfs.io/ipfs/<CID>
format is supported.Expected behavior
The proposal submission metadata anchor should support both
https://ipfs.io/ipfs/<CID>
andipfs://<CID>
formats, just like dRep registration does.Reference Ticket: #1616
The text was updated successfully, but these errors were encountered: