Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 IPFS URL Format Not Fully Supported in Proposal Submission Metadata Anchor URL #2495

Open
kneerose opened this issue Dec 10, 2024 · 4 comments
Assignees
Labels
🐛 Bug Something isn't working 📜 Proposal Pillar

Comments

@kneerose
Copy link
Contributor

Area

Proposal Pillar

Domain

dev-sanchogov.tools

Which wallet were you using?

No response

Context

I encountered an issue while trying to add an IPFS URL in the metadata anchor URL during proposal submission. The system does not support IPFS URLs in the ipfs://<CID> format, although it does support the https://ipfs.io/ipfs/<CID> format.

  • Supported on dRep Registration
    Both https://ipfs.io/ipfs/<CID> and ipfs://<CID> formats are supported.

image

  • Not Supported on Proposal Submission
    While the https://ipfs.io/ipfs/<CID> format is supported, the ipfs://<CID> format is not.
    image

Steps to reproduce

  1. Connect Wallet
  2. Create a proposal
  3. Add an IPFS URL in the proposal submission metadata anchor URL field in the ipfs://<CID> format
  4. Observe the error: "Invalid URL"

Actual behavior

The proposal submission does not support the ipfs://<CID> format in the metadata anchor URL field, even though the https://ipfs.io/ipfs/<CID> format is supported.

image

Expected behavior

The proposal submission metadata anchor should support both https://ipfs.io/ipfs/<CID> and ipfs://<CID> formats, just like dRep registration does.

Reference Ticket: #1616

@kneerose kneerose added the 🐛 Bug Something isn't working label Dec 10, 2024
@bosko-m bosko-m moved this to To do in Govtool all Dec 12, 2024
@nebojsact nebojsact moved this from To do to In progress in Govtool all Dec 25, 2024
@nebojsact nebojsact moved this from In progress to To do in Govtool all Dec 25, 2024
@nebojsact nebojsact assigned MSzalowski and unassigned nebojsact Dec 25, 2024
@nebojsact
Copy link

After detailed analyzing, this request is for @MSzalowski, in pdf is only form for submission, function and error checking is pulled from govtools (validateMetadata)

@MSzalowski MSzalowski assigned nebojsact and unassigned MSzalowski Dec 27, 2024
@m-i-k-e
Copy link

m-i-k-e commented Jan 7, 2025

Just tested it, and this is the result: https://www.loom.com/share/63db04e23475439ebe8bc96cc20a699e?sid=4bbf8e90-5235-4ae0-a3de-aea028661db1

GovTool does not find the URL, but the URL does exist and is browsable.

@MSzalowski MSzalowski moved this from To do to In progress in Govtool all Jan 7, 2025
@MSzalowski MSzalowski assigned MSzalowski and unassigned nebojsact Jan 7, 2025
@MSzalowski
Copy link
Contributor

MSzalowski commented Jan 7, 2025

On DRep registration:
I tested it as well and locally it works, here is the video presenting it:
https://github.com/user-attachments/assets/ba26602a-b345-4027-8ef4-f633acce927d

My metadata CID:
QmVJjHoz3abUGRfGNwDLRhSkomjPwqFYjmEimsY31nwe2d

Gateway used: https://ipfs.io

@MSzalowski
Copy link
Contributor

@nebojsact That issue is on the PDF level. As you said, the wrapper provided metadata validation but on the second screen, there is not metadata validation as that error is displayed on the form level.

I tested it using @intersect.mbo/[email protected] and that issue still exists.

IPFS is supported by both GovTool wrapper and GovTool metadata validation service as DRep registration using IPFS links works (DRep registration is on the Wrapper level so far, and it validates the metadata using the validation service).

Screenshot from postman using the ipfs link as a metadata source:
Zrzut ekranu z 2025-01-07 13-46-10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working 📜 Proposal Pillar
Projects
Status: No status
Status: In QA
Development

When branches are created from issues, their pull requests are automatically linked.

5 participants