Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conformance machinery can handle test names a bit misleadingly #6660

Open
kwxm opened this issue Nov 13, 2024 · 0 comments · May be fixed by #6730
Open

Conformance machinery can handle test names a bit misleadingly #6660

kwxm opened this issue Nov 13, 2024 · 0 comments · May be fixed by #6730

Comments

@kwxm
Copy link
Contributor

kwxm commented Nov 13, 2024

The conformance test machinery traverses the directory hierarchy looking for directories with no subdirectories and when it finds such a directory it checks that it contains exactly one .uplc file and loads it, executes it, and checks the result and budget against golden files in the same directory. However, it doesn't check that the name of the .uplc file matches that of the directory, but it does expect the golden files to have basenames that match the name of the directory. Thus if you have a directory called test-123 and it contains test-456.uplc it expects the golden files to be in test-123-uplc.expected and test-123.uplc.budget.expected. This can be confusing if you create a source file whose name doesn't match that of the directory containing it.

This issue emerged after PR #6627; see also #6659.

@kwxm kwxm self-assigned this Nov 13, 2024
@kwxm kwxm changed the title Conformance can handle test names a bit misleadingly Conformance machinery can handle test names a bit misleadingly Nov 13, 2024
@kwxm kwxm linked a pull request Dec 3, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant