Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function Explanation conflicts w/ Swift style guidelines #16

Open
loganwright opened this issue Feb 9, 2016 · 2 comments
Open

Function Explanation conflicts w/ Swift style guidelines #16

loganwright opened this issue Feb 9, 2016 · 2 comments

Comments

@loganwright
Copy link

https://github.com/IntrepidPursuits/swift-style-guide#declarations

We suggest moveView(view: UIView over move(view: UIView.

This conflicts with Swift's official design guidelines and should be updated.

@paulrolfe
Copy link

This might be related somewhat to #18 if we also consider the option move(view view: UIView) so the parameter has context when used.

@loganwright
Copy link
Author

@paulrolfe I think in this scenario, we wouldn't want the external since it only explains the type. The example from guidelines is add(view: View) where no type is necessary because it is identified in the signature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants