Haohao/fix halt problem #40
Conversation
Codecov Report
@@ Coverage Diff @@
## master #40 +/- ##
==========================================
+ Coverage 38.47% 38.70% +0.22%
==========================================
Files 6 6
Lines 512 509 -3
Branches 72 76 +4
==========================================
Hits 197 197
+ Misses 308 306 -2
+ Partials 7 6 -1
Continue to review full report at Codecov.
|
…into haohao/FixHaltProblem
iottalkpy/dai.py
Outdated
| import sys | ||
| import time | ||
| import traceback | ||
|
|
||
| from multiprocessing import Process, Manager | ||
| from threading import Thread, Event | ||
| from multiprocessing import Event as multiprocessingEvent |
iottalkpy/dai.py
Outdated
| @@ -25,6 +26,8 @@ | |||
| except ImportError: | |||
| pass | |||
|
|
|||
| terminate_event = multiprocessingEvent() | |||
There was a problem hiding this comment.
這樣的話，是 global 變數，這個 class DAI 如果有多個 instance 會發生啥事情？
There was a problem hiding this comment.
應該不會發生什麼奇怪的事情吧，當 terminate_event 被拉起來的時候，所有 DAI instances 應該都會終止
There was a problem hiding this comment.
hmmm 我在想這個 signal handler 會不會影響到 AG 的使用， AG 用 Django 跟 application server 打算用 UWSGI
iottalkpy/dai.py
Outdated
| until it actually exits. | ||
|
|
||
| Ref: | ||
| 1. https://stackoverflow.com/questions/43092371/ignore-sigint-in-python-multiprocessing-subprocess # noqa: E501 |
There was a problem hiding this comment.
用這篇的哪個 answer? 直接給 answer link 吧
| ret = super(DAI, self).start(*args, **kwargs) | ||
| # conduct deregistration properly, | ||
| # if one doesn't stop process before main process ends | ||
| atexit.register(self.terminate) |
There was a problem hiding this comment.
這個被拔掉後，main thread 結束，沒有送出 deregister message
In [5]: m = dai.load_module('./sa.py')
In [6]: m
Out[6]: <module 'sa' from '/home/iblis/git/iottalk-py/tmp/sa.py'>
In [7]: da = dai.module_to_sa(m)
In [8]: da
Out[8]: <DAI(DAI-1, initial daemon)>
In [9]: da.start
Out[9]: <bound method BaseProcess.start of <DAI(DAI-1, initial daemon)>>
In [10]: da.start()
In [11]: INFO:DAN:Successfully connect to http://panettone.iottalk.tw:11150/csm.
INFO:DAN:Device ID: ff73f56c-4439-46e4-81eb-03372e08e18d.
INFO:DAN:Device name: 00.Dummy_Device.
register successfully
INFO:DAI:Press Ctrl+C to exit DAI.
In [11]:
In [11]:
In [11]:
Do you really want to exit ([y]/n)? y
^CError in atexit._run_exitfuncs:
Traceback (most recent call last):
File "/usr/lib/python3.6/multiprocessing/popen_fork.py", line 28, in poll
pid, sts = os.waitpid(self.pid, flag)
KeyboardInterrupt
There was a problem hiding this comment.
我先把 PR 改成 Draft，之後來研究有沒有好的做法
Processclass 中不必要覆寫的 methods，同時移除 Manager 並直接使用 event